Skip to content
This repository was archived by the owner on May 28, 2025. It is now read-only.

Conversation

@ocofaigh
Copy link
Contributor

@ocofaigh ocofaigh commented Nov 29, 2024

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

Copy link
Member

@jor2 jor2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also change scope to scopes?

@ocofaigh
Copy link
Contributor Author

Lets hold off for now - scope is now a first class citizen, but the provider hasn't been updates yet to support managing scopes (coming in IBM-Cloud/terraform-provider-ibm#5731)

@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh ocofaigh merged commit b1d7f0c into main Nov 29, 2024
2 checks passed
@ocofaigh ocofaigh deleted the ocofaigh-patch-1 branch November 29, 2024 16:29
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.8.25 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants