Skip to content
This repository was archived by the owner on May 28, 2025. It is now read-only.

Add fix for EN integration #198

Merged
ocofaigh merged 2 commits into from
Nov 26, 2024
Merged

Add fix for EN integration #198

ocofaigh merged 2 commits into from
Nov 26, 2024

Conversation

@ocofaigh
Copy link
Contributor

@ocofaigh ocofaigh commented Nov 26, 2024 •
edited
Loading

Description

Added a fix for IBM-Cloud/terraform-provider-ibm#5817
This means a value needs to be passed for en_source_name when configuring EN integration now.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh
Copy link
Contributor Author

ocofaigh commented Nov 26, 2024

/run pipeline

@ocofaigh
Copy link
Contributor Author

ocofaigh commented Nov 26, 2024

The upgrade test failed:

│ Error: event_notifications.source_name needs to be defined along with event_notifications.instance_crn
│ 
│   with module.create_scc_instance.ibm_scc_instance_settings.scc_instance_settings[0],
│   on ../../main.tf line 89, in resource "ibm_scc_instance_settings" "scc_instance_settings":
│   89: resource "ibm_scc_instance_settings" "scc_instance_settings" {
│

This makes sense as the ability to set source_name only came in this PR. Skipping upgrade test..

@ocofaigh ocofaigh mentioned this pull request Nov 26, 2024
Merged
6 tasks
@ocofaigh
Copy link
Contributor Author

ocofaigh commented Nov 26, 2024

/run pipeline

@ocofaigh ocofaigh merged commit d0f25ba into main Nov 26, 2024
2 checks passed
@ocofaigh ocofaigh deleted the en-fix branch November 26, 2024 14:34
@terraform-ibm-modules-ops
Copy link
Contributor

terraform-ibm-modules-ops commented Nov 26, 2024

🎉 This PR is included in version 1.8.22 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@toddgiguere toddgiguere toddgiguere approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ocofaigh @terraform-ibm-modules-ops @toddgiguere