fix: updated the value of endpoint_type in the DA to be "private" and hide the variables from list of inputs user will see (#13)

Author: mukulpalit-ibm

README.md

@@ -43,7 +43,7 @@ module "custom_credential_engine" {
   secrets_manager_guid          = "<secrets_manager_instance_id>"
   secrets_manager_region        = "<secrets_manager_instance_region>"
   custom_credential_engine_name = "My Custom Credentials Engine"
-  endpoint_type                 = "public"
+  endpoint_type                 = "private"
   code_engine_project_id        = "<code_engine_project_id>"
   code_engine_job_name          = "<code_engine_project_job_name>"
   code_engine_region            = "<code_engine_region>"
@@ -105,7 +105,7 @@ You need the following permissions to run this module.
 | <a name="input_code_engine_project_id"></a> [code\_engine\_project\_id](#input\_code\_engine\_project\_id) | The Project ID of the code engine project used by the custom credentials configuration. | `string` | n/a | yes |
 | <a name="input_code_engine_region"></a> [code\_engine\_region](#input\_code\_engine\_region) | The region of the code engine project. | `string` | n/a | yes |
 | <a name="input_custom_credential_engine_name"></a> [custom\_credential\_engine\_name](#input\_custom\_credential\_engine\_name) | The name of the custom credentials engine to be created. | `string` | n/a | yes |
-| <a name="input_endpoint_type"></a> [endpoint\_type](#input\_endpoint\_type) | The endpoint type to communicate with the provided secrets manager instance. Possible values are `public` or `private`. | `string` | `"public"` | no |
+| <a name="input_endpoint_type"></a> [endpoint\_type](#input\_endpoint\_type) | The endpoint type to communicate with the provided secrets manager instance. Possible values are `public` or `private`. | `string` | `"private"` | no |
 | <a name="input_iam_credential_secret_auto_rotation_interval"></a> [iam\_credential\_secret\_auto\_rotation\_interval](#input\_iam\_credential\_secret\_auto\_rotation\_interval) | The rotation interval for the rotation policy. | `string` | `60` | no |
 | <a name="input_iam_credential_secret_auto_rotation_unit"></a> [iam\_credential\_secret\_auto\_rotation\_unit](#input\_iam\_credential\_secret\_auto\_rotation\_unit) | The unit of time for rotation policy. Acceptable values are `day` or `month`. | `string` | `"day"` | no |
 | <a name="input_iam_credential_secret_group_id"></a> [iam\_credential\_secret\_group\_id](#input\_iam\_credential\_secret\_group\_id) | Secret Group ID of secret where IAM Secret will be added to, leave default (null) to add in the default secret group. | `string` | `null` | no |

ibm_catalog.json

@@ -178,6 +178,7 @@
             },
             {
               "key": "endpoint_type",
+              "hidden": true,
               "options": [
                 {
                   "displayname": "private",

solutions/fully-configurable/variables.tf

@@ -65,7 +65,7 @@ variable "skip_secrets_manager_code_engine_auth_policy" {
 variable "endpoint_type" {
   type        = string
   description = "The endpoint type to communicate with the provided secrets manager instance. Possible values are `public` or `private`"
-  default     = "public"
+  default     = "private"
 
   validation {
     condition     = contains(["public", "private"], var.endpoint_type)

tests/pr_test.go

@@ -27,7 +27,6 @@ var permanentResources map[string]interface{}
 
 // TestMain will be run before any parallel tests, used to read data from yaml for use with tests
 func TestMain(m *testing.M) {
-
 	var err error
 	permanentResources, err = common.LoadMapFromYaml(yamlLocation)
 	if err != nil {

variables.tf

@@ -26,7 +26,7 @@ variable "skip_secrets_manager_code_engine_auth_policy" {
 variable "endpoint_type" {
   type        = string
   description = "The endpoint type to communicate with the provided secrets manager instance. Possible values are `public` or `private`."
-  default     = "public"
+  default     = "private"
   validation {
     condition     = contains(["public", "private"], var.endpoint_type)
     error_message = "The specified endpoint_type is not a valid selection!"