From 6d1e47064c494401a9bb9eda86adec6c41e8cc36 Mon Sep 17 00:00:00 2001 From: mukul-palit Date: Tue, 16 Sep 2025 15:14:39 +0530 Subject: [PATCH 1/4] Update endpoint typw --- README.md | 2 +- solutions/fully-configurable/variables.tf | 2 +- variables.tf | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 738fa9e..53a57ca 100644 --- a/README.md +++ b/README.md @@ -43,7 +43,7 @@ module "custom_credential_engine" { secrets_manager_guid = "" secrets_manager_region = "" custom_credential_engine_name = "My Custom Credentials Engine" - endpoint_type = "public" + endpoint_type = "private" code_engine_project_id = "" code_engine_job_name = "" code_engine_region = "" diff --git a/solutions/fully-configurable/variables.tf b/solutions/fully-configurable/variables.tf index 7f34a32..bdf2119 100644 --- a/solutions/fully-configurable/variables.tf +++ b/solutions/fully-configurable/variables.tf @@ -65,7 +65,7 @@ variable "skip_secrets_manager_code_engine_auth_policy" { variable "endpoint_type" { type = string description = "The endpoint type to communicate with the provided secrets manager instance. Possible values are `public` or `private`" - default = "public" + default = "private" validation { condition = contains(["public", "private"], var.endpoint_type) diff --git a/variables.tf b/variables.tf index 031c0d5..3b18aa0 100644 --- a/variables.tf +++ b/variables.tf @@ -26,7 +26,7 @@ variable "skip_secrets_manager_code_engine_auth_policy" { variable "endpoint_type" { type = string description = "The endpoint type to communicate with the provided secrets manager instance. Possible values are `public` or `private`." - default = "public" + default = "private" validation { condition = contains(["public", "private"], var.endpoint_type) error_message = "The specified endpoint_type is not a valid selection!" From 9667694c04384c59dc5c7a65febcb7c9018fda6a Mon Sep 17 00:00:00 2001 From: mukul-palit Date: Tue, 16 Sep 2025 18:17:16 +0530 Subject: [PATCH 2/4] pre-commit --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 53a57ca..b60fab4 100644 --- a/README.md +++ b/README.md @@ -105,7 +105,7 @@ You need the following permissions to run this module. | [code\_engine\_project\_id](#input\_code\_engine\_project\_id) | The Project ID of the code engine project used by the custom credentials configuration. | `string` | n/a | yes | | [code\_engine\_region](#input\_code\_engine\_region) | The region of the code engine project. | `string` | n/a | yes | | [custom\_credential\_engine\_name](#input\_custom\_credential\_engine\_name) | The name of the custom credentials engine to be created. | `string` | n/a | yes | -| [endpoint\_type](#input\_endpoint\_type) | The endpoint type to communicate with the provided secrets manager instance. Possible values are `public` or `private`. | `string` | `"public"` | no | +| [endpoint\_type](#input\_endpoint\_type) | The endpoint type to communicate with the provided secrets manager instance. Possible values are `public` or `private`. | `string` | `"private"` | no | | [iam\_credential\_secret\_auto\_rotation\_interval](#input\_iam\_credential\_secret\_auto\_rotation\_interval) | The rotation interval for the rotation policy. | `string` | `60` | no | | [iam\_credential\_secret\_auto\_rotation\_unit](#input\_iam\_credential\_secret\_auto\_rotation\_unit) | The unit of time for rotation policy. Acceptable values are `day` or `month`. | `string` | `"day"` | no | | [iam\_credential\_secret\_group\_id](#input\_iam\_credential\_secret\_group\_id) | Secret Group ID of secret where IAM Secret will be added to, leave default (null) to add in the default secret group. | `string` | `null` | no | From 7adb804ef19f9b3f3eada0f99caaaf9d3a640d2d Mon Sep 17 00:00:00 2001 From: mukul-palit Date: Tue, 16 Sep 2025 18:44:35 +0530 Subject: [PATCH 3/4] endpoint SKIP UPGRADE TEST --- tests/pr_test.go | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/pr_test.go b/tests/pr_test.go index bbe5905..a9850e2 100644 --- a/tests/pr_test.go +++ b/tests/pr_test.go @@ -27,7 +27,6 @@ var permanentResources map[string]interface{} // TestMain will be run before any parallel tests, used to read data from yaml for use with tests func TestMain(m *testing.M) { - var err error permanentResources, err = common.LoadMapFromYaml(yamlLocation) if err != nil { From a3fbb792711f48a5dd1740ff2f43effd46080981 Mon Sep 17 00:00:00 2001 From: mukul-palit Date: Tue, 16 Sep 2025 19:34:14 +0530 Subject: [PATCH 4/4] make endpoint as hidden --- ibm_catalog.json | 1 + 1 file changed, 1 insertion(+) diff --git a/ibm_catalog.json b/ibm_catalog.json index e9b2318..3ae70de 100644 --- a/ibm_catalog.json +++ b/ibm_catalog.json @@ -178,6 +178,7 @@ }, { "key": "endpoint_type", + "hidden": true, "options": [ { "displayname": "private",