Skip to content

Commit a9d5e8a

Browse files
Khuzaima05Khuzaima-Shakeel
andauthored
chore: updated to consume tim secret manager module (#151)
Co-authored-by: Khuzaima-Shakeel <[email protected]>
1 parent 00166e6 commit a9d5e8a

File tree

2 files changed

+10
-13
lines changed

2 files changed

+10
-13
lines changed

examples/default/main.tf

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
locals {
2-
sm_guid = var.existing_sm_instance_guid == null ? ibm_resource_instance.secrets_manager[0].guid : var.existing_sm_instance_guid
2+
sm_guid = var.existing_sm_instance_guid == null ? module.secrets_manager.secrets_manager_guid : var.existing_sm_instance_guid
33
sm_region = var.existing_sm_instance_region == null ? var.region : var.existing_sm_instance_region
44
}
55

@@ -11,17 +11,15 @@ module "resource_group" {
1111
existing_resource_group_name = var.resource_group
1212
}
1313

14-
resource "ibm_resource_instance" "secrets_manager" {
15-
count = var.existing_sm_instance_guid == null ? 1 : 0
16-
name = "${var.prefix}-secrets-manager" #tfsec:ignore:general-secrets-no-plaintext-exposure
17-
service = "secrets-manager"
18-
plan = "trial"
19-
location = local.sm_region
20-
tags = var.resource_tags
21-
resource_group_id = module.resource_group.resource_group_id
22-
timeouts {
23-
create = "20m" # Extending provisioning time to 20 minutes
24-
}
14+
module "secrets_manager" {
15+
source = "terraform-ibm-modules/secrets-manager/ibm"
16+
version = "1.1.0"
17+
resource_group_id = module.resource_group.resource_group_id
18+
region = var.region
19+
secrets_manager_name = "${var.prefix}-secrets-manager"
20+
sm_service_plan = "trial"
21+
service_endpoints = "public-and-private"
22+
sm_tags = var.resource_tags
2523
}
2624

2725
# Best practice, use a secret group

examples/default/version.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
terraform {
22
required_version = ">= 1.3.0, <1.6.0"
33
required_providers {
4-
# Pin to the lowest provider version of the range defined in the main module's version.tf to ensure lowest version still works
54
ibm = {
65
source = "IBM-Cloud/ibm"
76
version = "1.61.0"

0 commit comments

Comments
 (0)