fix: Addressed comments

Arya Girish K · Arya Girish K · commit 8ceacd80212d · 2025-10-30T15:18:40.000+05:30
diff --git a/ibm_catalog.json b/ibm_catalog.json
@@ -156,7 +156,7 @@
                 {
                   "type": "regex",
                   "description": "The value provided for 'existing_secrets_manager_crn' is not valid.",
-                  "value": "^__NULL__$|^crn:(.*:){3}secrets-manager:(.*:){2}[0-9a-fA-F]{8}(?:-[0-9a-fA-F]{4}){3}-[0-9a-fA-F]{12}::$"
+                  "value": "^crn:(.*:){3}secrets-manager:(.*:){2}[0-9a-fA-F]{8}(?:-[0-9a-fA-F]{4}){3}-[0-9a-fA-F]{12}::$"
                 }
               ]
             },
diff --git a/solutions/fully-configurable/variables.tf b/solutions/fully-configurable/variables.tf
@@ -17,6 +17,7 @@ variable "provider_visibility" {
 
 variable "existing_secrets_manager_crn" {
   type        = string
+  nullable    = false
   description = "CRN of an existing secrets manager instance to create the secret engine in."
 }
 

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@`
`156`	`156`	`{`
`157`	`157`	`"type": "regex",`
`158`	`158`	`"description": "The value provided for 'existing_secrets_manager_crn' is not valid.",`
`159`		`- "value": "^__NULL__$\|^crn:(.:){3}secrets-manager:(.:){2}[0-9a-fA-F]{8}(?:-[0-9a-fA-F]{4}){3}-[0-9a-fA-F]{12}::$"`
	`159`	`+ "value": "^crn:(.:){3}secrets-manager:(.:){2}[0-9a-fA-F]{8}(?:-[0-9a-fA-F]{4}){3}-[0-9a-fA-F]{12}::$"`
`160`	`160`	`}`
`161`	`161`	`]`
`162`	`162`	`},`
Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@ variable "provider_visibility" {`
`17`	`17`
`18`	`18`	`variable "existing_secrets_manager_crn" {`
`19`	`19`	`type = string`
	`20`	`+ nullable = false`
`20`	`21`	`description = "CRN of an existing secrets manager instance to create the secret engine in."`
`21`	`22`	`}`
`22`	`23`