Skip to content

Conversation

@kierramarie
Copy link
Member

@kierramarie kierramarie commented Feb 11, 2025

Description

A private only example already exists in this repo, so it was just adjusted to allow for an existing secrets manager to be passed in and the test adjusted to use our permanent private only secrets manager.

Git Issue: #73

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@kierramarie
Copy link
Member Author

/run pipeline

@kierramarie
Copy link
Member Author

/run pipeline

@kierramarie
Copy link
Member Author

/run pipeline

Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is a test-only change, so no release is required.

@kierramarie
Copy link
Member Author

/run pipeline

@toddgiguere toddgiguere merged commit 72b4206 into main Feb 19, 2025
2 checks passed
@toddgiguere toddgiguere deleted the ks-priv-only branch February 19, 2025 18:37
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.0.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants