SM public cert engine DA feedback

[ocofaigh]

• The prefix input variable mentions Example: prod-0205-cos however there is no COS in play here. Suggest to use a better more real life example for this DA
• Input mappings are missing in the addons config for secrets manager DA:
  • prefix
  • service_plan (add this as a new required virtual input and map to SM input)
  • enable_platform_metrics (add this as a required virtual input and map to SM virtual input)
  • logs_routing_tenant_regions (add this as a required virtual input and map to SM virtual input)
• If a user were to proceed by only entering the values of the inputs in the required tab, the DA will fail. This is because the DA either requires an input for private_key_secrets_manager_secret_crn or acme_letsencrypt_private_key. I would suggest marking acme_letsencrypt_private_key as required, but to reference private_key_secrets_manager_secret_crn in the variable description as an alternative. Also cane we be consistent with these variable names please. Perhaps rename private_key_secrets_manager_secret_crn -> acme_letsencrypt_private_key_secrets_manager_secret_crn
• I'm trying to figure out if internet_services_crn is required. This information should be included in the variable description. When or what use case would user need a value for this. I think you need to revisit all of the optional input and add more details to when values would be needed to the variable descriptions.
• You can remove TestRunUpgradeExample - we only have upgrade test on DA now

[ocofaigh]

With default values, DA is failing with:

 2025/06/23 11:57:08 Terraform plan | Error: Invalid value for variable
 2025/06/23 11:57:08 Terraform plan | 
 2025/06/23 11:57:08 Terraform plan |   on main.tf line 38, in module "secrets_manager_public_cert_engine":
 2025/06/23 11:57:08 Terraform plan |   38:   internet_services_crn                     = var.internet_services_crn
 2025/06/23 11:57:08 Terraform plan |     ├────────────────
 2025/06/23 11:57:08 Terraform plan |     │ var.dns_config_name is "con-sm-certificate-dns"
 2025/06/23 11:57:08 Terraform plan |     │ var.internet_services_crn is null
 2025/06/23 11:57:08 Terraform plan | 
 2025/06/23 11:57:08 Terraform plan | A value for 'internet_services_crn' must be passed to create a DNS config for
 2025/06/23 11:57:08 Terraform plan | public_cert secrets engine
 2025/06/23 11:57:08 Terraform plan | 
 2025/06/23 11:57:08 Terraform plan | This was checked by the validation rule at ../../variables.tf:28,3-13.
 2025/06/23 11:57:08 Terraform plan | 
 2025/06/23 11:57:08 Terraform plan | Error: Invalid value for variable
 2025/06/23 11:57:08 Terraform plan | 
 2025/06/23 11:57:08 Terraform plan |   on schematics.tfvars line 12:
 2025/06/23 11:57:08 Terraform plan |   12: private_key_secrets_manager_secret_crn = null
 2025/06/23 11:57:08 Terraform plan |     ├────────────────
 2025/06/23 11:57:08 Terraform plan |     │ var.private_key_secrets_manager_secret_crn is null
 2025/06/23 11:57:08 Terraform plan | 
 2025/06/23 11:57:08 Terraform plan | If `acme_letsencrypt_private_key` is not set, you must provide a value for
 2025/06/23 11:57:08 Terraform plan | `private_key_secrets_manager_secret_crn`.
 2025/06/23 11:57:08 Terraform plan | 
 2025/06/23 11:57:08 Terraform plan | This was checked by the validation rule at variables.tf:106,3-13.
 2025/06/23 11:57:08 Terraform plan | 
 2025/06/23 11:57:08 Terraform plan | Planning failed. Terraform encountered an error while generating this plan.
 2025/06/23 11:57:08 Terraform plan | 

[Aayush-Abhyarthi]

PR merged. Closing this