-
Notifications
You must be signed in to change notification settings - Fork 0
fix: crn parser #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: crn parser #241
Conversation
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about plugging the test gap? Why did our tests not catch this bug?
|
@ocofaigh We will have to pass |
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aayush-Abhyarthi You can add a plan only test and pass a mock value for the ACME key
|
/run pipeline |
|
🎉 This PR is included in version 1.1.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
https://github.ibm.com/GoldenEye/issues/issues/14472
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Fix crn parser.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers