refactor: Update variable handling to correctly support null for dns_config_name and ca_config_name

[aatreyee257]

Description

Changed the variable handling of ca_config_name so that the default value is null.

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Changed the variable handling of ca_config_name so that the default value is null.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[aatreyee257]

/run pipeline

[aatreyee257]

/run pipeline

[shemau]

This is not what I intended during the discussion. Sorry to have caused confusion.

The aim was to allow null to be passed, not necessarily to default to null. So I was thinking original code

ca_config_name                            = "${local.prefix}${var.ca_config_name}"

was passing "" or "$local.prefix" when var.ca_config_name was set to null by the consumer. That would likely cause an error.

Thus a likely fix (and doing the same for dns_config_name)

dns_config_name   = dns_config_name == null ? null : "${local.prefix}${var.dns_config_name}"
ca_config_name     = ca_config_name == null ? null : "${local.prefix}${var.ca_config_name}"

This module can add one CA config, one DNS config, or one of both. Thus it accepts nulls to support the just one scenarios. The DA by default adds one of both.

[aatreyee257]

The upgrade test is failing because we added the optional prefix for dns_config_name. This changes the name of the resource ibm_sm_public_certificate_configuration_dns_cis.public_dns_config from cert-dns to <prefix>-cert-dns.
Hence, skipping upgrade test.

[aatreyee257]

/run pipeline

[aatreyee257]

/run pipeline

[aatreyee257]

/run pipeline

[aatreyee257]

/run pipeline

[shemau]

Looks good to me.

[terraform-ibm-modules-ops]

🎉 This PR is included in version 1.2.4 🎉

The release is available on:

• GitHub release
• v1.2.4

Your semantic-release bot 📦🚀