Skip to content

feat: Add UI regex validation #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+48 −4
Open

feat: Add UI regex validation #287

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
668ea21
feat: Add UI regex validation
Oct 24, 2025
868101e
Merge branch 'main' into regex-validation
arya-girish-k Oct 28, 2025
8ceacd8
fix: Addressed comments
Oct 30, 2025
3e2b76f
fix: added validation in variable.tf
Oct 31, 2025
f65ec65
Merge branch 'main' into regex-validation
arya-girish-k Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions ibm_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,14 @@
},
{
"key": "existing_secrets_manager_crn",
"required": true
"required": true,
"value_constraints": [
{
"type": "regex",
"description": "The value provided for 'existing_secrets_manager_crn' is not valid.",
"value": "^__NULL__$|^crn:(.*:){3}secrets-manager:(.*:){2}[0-9a-fA-F]{8}(?:-[0-9a-fA-F]{4}){3}-[0-9a-fA-F]{12}::$"
}
]
},
{
"key": "prefix",
Expand Down Expand Up @@ -262,7 +269,14 @@
"key": "ibmcloud_cis_api_key"
},
{
"key": "internet_services_crn"
"key": "internet_services_crn",
"value_constraints": [
{
"type": "regex",
"description": "The value provided for 'internet_services_crn' is not valid.",
"value": "^__NULL__$|^crn:(.*:){3}internet-svcs:(.*:){2}[0-9a-fA-F]{8}(?:-[0-9a-fA-F]{4}){3}-[0-9a-fA-F]{12}::$"
}
]
},
{
"key": "internet_services_account_id"
Expand Down Expand Up @@ -294,7 +308,14 @@
"required": true
},
{
"key": "acme_letsencrypt_private_key_secrets_manager_secret_crn"
"key": "acme_letsencrypt_private_key_secrets_manager_secret_crn",
"value_constraints": [
{
"type": "regex",
"description": "The value provided for 'acme_letsencrypt_private_key_secrets_manager_secret_crn' is not valid.",
"value": "^__NULL__$|^crn:(.*:){3}secrets-manager:(.*:){2}[0-9a-fA-F]{8}(?:-[0-9a-fA-F]{4}){3}-[0-9a-fA-F]{12}:secret:[0-9a-fA-F]{8}(?:-[0-9a-fA-F]{4}){3}-[0-9a-fA-F]{12}$"
}
]
},
{
"key": "skip_iam_authorization_policy"
Expand Down
2 changes: 1 addition & 1 deletion solutions/fully-configurable/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ variable "existing_secrets_manager_crn" {
variable "prefix" {
type = string
nullable = true
description = "The prefix to be added to all resources created by this solution. To skip using a prefix, set this value to null or an empty string. The prefix must begin with a lowercase letter and may contain only lowercase letters, digits, and hyphens '-'. It should not exceed 16 characters, must not end with a hyphen('-'), and can not contain consecutive hyphens ('--'). Example: prod-us-south. [Learn more](https://terraform-ibm-modules.github.io/documentation/#/prefix.md)."
description = "The prefix to add to all resources that this solution creates (e.g `prod`, `test`, `dev`). To skip using a prefix, set this value to null or an empty string. [Learn more](https://terraform-ibm-modules.github.io/documentation/#/prefix.md)."

validation {
# - null and empty string is allowed
Expand Down