Skip to content

Commit 65631f3

Browse files
authored
fix: fixed bug which was causing private endpoint not to be used (#38)
1 parent 7e8ec95 commit 65631f3

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

main.tf

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ resource "ibm_sm_arbitrary_secret" "arbitrary_secret" {
3737
description = var.secret_description
3838
labels = var.secret_labels
3939
payload = var.secret_payload_password
40+
endpoint_type = var.service_endpoints
4041
}
4142

4243
resource "ibm_sm_username_password_secret" "username_password_secret" {
@@ -49,6 +50,7 @@ resource "ibm_sm_username_password_secret" "username_password_secret" {
4950
labels = var.secret_labels
5051
username = var.secret_username
5152
password = var.secret_payload_password
53+
endpoint_type = var.service_endpoints
5254

5355
## This for_each block is NOT a loop to attach to multiple rotation blocks.
5456
## This block is only used to conditionally add rotation block depending on var.sm_iam_secret_auto_rotation
@@ -81,6 +83,7 @@ resource "ibm_sm_imported_certificate" "imported_cert" {
8183
certificate = local.imported_cert_certificate
8284
private_key = local.imported_cert_private_key
8385
intermediate = local.imported_cert_intermediate
86+
endpoint_type = var.service_endpoints
8487
}
8588

8689
# Parse secret ID and generate data header for secrets

module-metadata.json

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,11 @@
211211
"type": "string",
212212
"description": "The service endpoint type to communicate with the provided secrets manager instance. Possible values are `public` or `private`",
213213
"default": "public",
214+
"source": [
215+
"ibm_sm_arbitrary_secret.arbitrary_secret.endpoint_type",
216+
"ibm_sm_imported_certificate.imported_cert.endpoint_type",
217+
"ibm_sm_username_password_secret.username_password_secret.endpoint_type"
218+
],
214219
"pos": {
215220
"filename": "variables.tf",
216221
"line": 91
@@ -283,6 +288,7 @@
283288
"attributes": {
284289
"count": "secret_type",
285290
"description": "secret_description",
291+
"endpoint_type": "service_endpoints",
286292
"instance_id": "secrets_manager_guid",
287293
"labels": "secret_labels",
288294
"name": "secret_name",
@@ -305,6 +311,7 @@
305311
"attributes": {
306312
"count": "secret_type",
307313
"description": "secret_description",
314+
"endpoint_type": "service_endpoints",
308315
"instance_id": "secrets_manager_guid",
309316
"labels": "secret_labels",
310317
"name": "secret_name",
@@ -316,7 +323,7 @@
316323
},
317324
"pos": {
318325
"filename": "main.tf",
319-
"line": 73
326+
"line": 75
320327
}
321328
},
322329
"ibm_sm_username_password_secret.username_password_secret": {
@@ -326,6 +333,7 @@
326333
"attributes": {
327334
"count": "secret_type",
328335
"description": "secret_description",
336+
"endpoint_type": "service_endpoints",
329337
"instance_id": "secrets_manager_guid",
330338
"labels": "secret_labels",
331339
"name": "secret_name",
@@ -339,7 +347,7 @@
339347
},
340348
"pos": {
341349
"filename": "main.tf",
342-
"line": 42
350+
"line": 43
343351
}
344352
}
345353
},

0 commit comments

Comments
 (0)