test: remove unused variables in test (#399)

alex-reiff · web-flow · commit 1d86faeb9734 · 2025-09-03T08:04:08.000+01:00
diff --git a/modules/fscloud/README.md b/modules/fscloud/README.md
@@ -20,7 +20,6 @@ module "secrets_manager" {
   resource_group_id          = "xxXXxxXXxXxXXXXxxXxxxXXXXxXXXXX"
   region                     = "us-south"
   secrets_manager_name       = "my-secrets-manager"
-  existing_kms_instance_guid = var.existing_kms_instance_guid
   kms_key_crn                = var.kms_key_crn
 }
 ```
diff --git a/tests/other_test.go b/tests/other_test.go
@@ -63,9 +63,7 @@ func TestFSCloudInSchematics(t *testing.T) {
 		{Name: "ibmcloud_api_key", Value: options.RequiredEnvironmentVars["TF_VAR_ibmcloud_api_key"], DataType: "string", Secure: true},
 		{Name: "region", Value: validRegions[rand.Intn(len(validRegions))], DataType: "string"},
 		{Name: "prefix", Value: options.Prefix, DataType: "string"},
-		{Name: "existing_kms_instance_guid", Value: permanentResources["hpcs_south"], DataType: "string"},
 		{Name: "kms_key_crn", Value: permanentResources["hpcs_south_root_key_crn"], DataType: "string"},
-		{Name: "sm_service_plan", Value: "trial", DataType: "string"},
 	}
 
 	err := options.RunSchematicTest()

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,6 @@ module "secrets_manager" {`
`20`	`20`	`resource_group_id = "xxXXxxXXxXxXXXXxxXxxxXXXXxXXXXX"`
`21`	`21`	`region = "us-south"`
`22`	`22`	`secrets_manager_name = "my-secrets-manager"`
`23`		`- existing_kms_instance_guid = var.existing_kms_instance_guid`
`24`	`23`	`kms_key_crn = var.kms_key_crn`
`25`	`24`	`}`
`26`	`25`	```
Original file line number	Diff line number	Diff line change
`@@ -63,9 +63,7 @@ func TestFSCloudInSchematics(t *testing.T) {`
`63`	`63`	`{Name: "ibmcloud_api_key", Value: options.RequiredEnvironmentVars["TF_VAR_ibmcloud_api_key"], DataType: "string", Secure: true},`
`64`	`64`	`{Name: "region", Value: validRegions[rand.Intn(len(validRegions))], DataType: "string"},`
`65`	`65`	`{Name: "prefix", Value: options.Prefix, DataType: "string"},`
`66`		`- {Name: "existing_kms_instance_guid", Value: permanentResources["hpcs_south"], DataType: "string"},`
`67`	`66`	`{Name: "kms_key_crn", Value: permanentResources["hpcs_south_root_key_crn"], DataType: "string"},`
`68`		`- {Name: "sm_service_plan", Value: "trial", DataType: "string"},`
`69`	`67`	`}`
`70`	`68`
`71`	`69`	`err := options.RunSchematicTest()`