Skip to content

Commit 2086f40

Browse files
committed
added to sec enforced, added secondary link
1 parent 821e263 commit 2086f40

File tree

5 files changed

+50
-3
lines changed

5 files changed

+50
-3
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ You need the following permissions to run this module.
121121
| <a name="output_secret_groups"></a> [secret\_groups](#output\_secret\_groups) | IDs of the created Secret Group |
122122
| <a name="output_secrets"></a> [secrets](#output\_secrets) | List of secret mananger secret config data |
123123
| <a name="output_secrets_manager_crn"></a> [secrets\_manager\_crn](#output\_secrets\_manager\_crn) | CRN of the Secrets Manager instance |
124+
| <a name="output_secrets_manager_dashboard_url"></a> [secrets\_manager\_dashboard\_url](#output\_secrets\_manager\_dashboard\_url) | Secrets Manager dashboard url. |
124125
| <a name="output_secrets_manager_guid"></a> [secrets\_manager\_guid](#output\_secrets\_manager\_guid) | GUID of Secrets Manager instance |
125126
| <a name="output_secrets_manager_id"></a> [secrets\_manager\_id](#output\_secrets\_manager\_id) | ID of the Secrets Manager instance |
126127
| <a name="output_secrets_manager_name"></a> [secrets\_manager\_name](#output\_secrets\_manager\_name) | Name of the Secrets Manager instance |

outputs.tf

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,9 @@ output "secrets" {
3737
value = module.secrets.secrets
3838
description = "List of secret mananger secret config data"
3939
}
40+
41+
output "secrets_manager_dashboard_url" {
42+
description = "Secrets Manager dashboard url."
43+
value = var.existing_sm_instance_crn != null ? "" : ibm_resource_instance.secrets_manager_instance[0].dashboard_url
44+
}
4045
##############################################################################

solutions/fully-configurable/outputs.tf

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ output "secrets_manager_region" {
3434
}
3535

3636
output "next_steps_text" {
37-
value = "Congratulations! You successfully deployed your changes. Next, view your Secrets Manager instance."
37+
value = "Congratulations! Click the link below to go your Secrets Manager instance. Refer to this deployment guide/documentation for more information."
3838
description = "Next steps text"
3939
}
4040

@@ -43,7 +43,23 @@ output "next_step_primary_label" {
4343
description = "Primary label"
4444
}
4545

46+
47+
output "secrets_manager_dashboard_url" {
48+
description = "Secrets Manager dashboard url."
49+
value = var.existing_secrets_manager_crn != null ? "" : module.secrets_manager.secrets_manager_dashboard_url
50+
}
51+
4652
output "next_step_primary_url" {
47-
value = "https://cloud.ibm.com/services/secrets-manager/${local.secrets_manager_crn}"
53+
value = module.secrets_manager.secrets_manager_dashboard_url
4854
description = "primary url"
4955
}
56+
57+
output "next_step_secondary_label" {
58+
value = "Check out related Deployable Architectures"
59+
description = "Secondary label"
60+
}
61+
62+
output "next_step_secondary_url" {
63+
value = "https://cloud.ibm.com/catalog?search=Secrets%20Manager%20label%3Adeployable_architecture#search_results"
64+
description = "Secondary url"
65+
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
# Cloud automation for Secrets Manager (Security enforced)
22

3-
:exclamation: **Important:** This solution is not intended to be called by other modules because it contains a provider configuration and is not compatible with the `for_each`, `count`, and `depends_on` arguments. For more information, see [Providers Within Modules](https://developer.hashicorp.com/terraform/language/modules/develop/providers).
3+
:exclamation: **Important:** This solution is not intended to be called by other modules because it contains a provider configuration and is not compatible with the `for_each`, `count`, and `depends_on` arguments. For more information, see [Providers Within Modules](https://developer.hashicorp.com/terraform/language/modules/develop/providers).

solutions/security-enforced/outputs.tf

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,3 +22,28 @@ output "secrets_manager_crn" {
2222
description = "CRN of Secrets Manager instance."
2323
value = module.secrets_manager.secrets_manager_crn
2424
}
25+
26+
output "next_steps_text" {
27+
value = "Congratulations! Click the link below to go your Secrets Manager instance. Refer to this deployment guide/documentation for more information."
28+
description = "Next steps text"
29+
}
30+
31+
output "next_step_primary_label" {
32+
value = "View Secrets Manager"
33+
description = "Primary label"
34+
}
35+
36+
output "next_step_primary_url" {
37+
value = module.secrets_manager.secrets_manager_dashboard_url
38+
description = "primary url"
39+
}
40+
41+
output "next_step_secondary_label" {
42+
value = "Check out related Deployable Architectures"
43+
description = "Secondary label"
44+
}
45+
46+
output "next_step_secondary_url" {
47+
value = "https://cloud.ibm.com/catalog?search=Secrets%20Manager%20label%3Adeployable_architecture#search_results"
48+
description = "Secondary url"
49+
}

0 commit comments

Comments
 (0)