-
Notifications
You must be signed in to change notification settings - Fork 3
DA consuming fscloud #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DA consuming fscloud #259
Conversation
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aayush-Abhyarthi I would of expected this change to fail upgrade test, but seems we dont have an upgrade test for DA! This is a gap we need to plug first before making this change. Can you add it please?
In terms of breaking change, ideally we need to find a way to migrate the config so its not a breaking change. I’m not sure how easy that will be, or if its even possible. You will have to experiment with moved blocks to see what we can do.
|
/run pipeline |
|
/run pipeline |
|
🎉 This PR is included in version 1.23.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
#253
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
This PR updates the DA to now consume the fscloud submodule instead of directly consuming the root module.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers