Skip to content

Conversation

@Aayush-Abhyarthi
Copy link
Member

@Aayush-Abhyarthi Aayush-Abhyarthi commented Dec 23, 2024

Description

#253

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

This PR updates the DA to now consume the fscloud submodule instead of directly consuming the root module.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi Aayush-Abhyarthi marked this pull request as ready for review January 2, 2025 05:47
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aayush-Abhyarthi I would of expected this change to fail upgrade test, but seems we dont have an upgrade test for DA! This is a gap we need to plug first before making this change. Can you add it please?

In terms of breaking change, ideally we need to find a way to migrate the config so its not a breaking change. I’m not sure how easy that will be, or if its even possible. You will have to experiment with moved blocks to see what we can do.

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit cc1ef7f into main Feb 7, 2025
2 checks passed
@ocofaigh ocofaigh deleted the consume-fscloud branch February 7, 2025 16:10
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants