feat: import existing GUID

[alex-reiff]

Description

Add support for passing in an existing instance's GUID and region.

issue: #270

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[alex-reiff]

/run pipeline

[ocofaigh]

@alex-reiff I don't understand why you wan't to do this? By asking for the CRN, we can parse the GUID and the region from it. So there is less user inputs needed. Why would you want to change that?

[alex-reiff]

@ocofaigh This doesn't remove the CRN input, only adding an optional input.

There are downstream modules that only have GUID as input so trying to unify them.
Example that started this: https://github.com/terraform-ibm-modules/terraform-ibm-secrets-manager-secret-group/blob/main/variables.tf

[ocofaigh]

But @alex-reiff The GUID can be parsed from the existing_sm_instance_crn input. So you don't need to add a new existing_sm_instance_guid input.

[alex-reiff]

@ocofaigh Yes, but if the user only has the GUID & region of their instance, they are unable to import their instance into the module. They need to provide the entire CRN even though we only use the GUID and region fields.

[ocofaigh]

@alex-reiff I'm not sure I follow - can you set up a quick call to explain?

[alex-reiff]

closing as unneeded after discussion.