Skip to content

Conversation

@jor2
Copy link
Member

@jor2 jor2 commented Jul 9, 2025

Description

Secrets Manager DA failing with invalid kms key crn parser

if the key exists, parse it. If it does not exist, skip. Will the key parse be needed? Doesn't matter.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 self-assigned this Jul 9, 2025
@jor2 jor2 requested review from alex-reiff and shemau as code owners July 9, 2025 14:12
@jor2
Copy link
Member Author

jor2 commented Jul 9, 2025

/run pipeline

shemau
shemau previously approved these changes Jul 9, 2025
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jor2
Copy link
Member Author

jor2 commented Jul 14, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Jul 16, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Jul 16, 2025

/run pipeline

@ocofaigh ocofaigh merged commit 37290f7 into main Jul 16, 2025
2 checks passed
@ocofaigh ocofaigh deleted the fix-bug-da branch July 16, 2025 17:26
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.6.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants