Skip to content

Conversation

@whoffler
Copy link
Contributor

@whoffler whoffler commented Jul 24, 2025

Description

for issue - https://github.ibm.com/GoldenEye/issues/issues/13756

add next steps for user when DA is deployed successfully

image

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@whoffler
Copy link
Contributor Author

/run pipeline

@rajatagarwal-ibm
Copy link
Member

I have 2 concerns

  1. How will it work when the resources are created in another account?
  2. In addons flow, bringing up resources up/down based on the positioning of this module wouldbe challenging if not possible with the current setup

}

output "next_step_primary_url" {
value = "https://cloud.ibm.com/services/secrets-manager/${local.secrets_manager_crn}"
Copy link
Contributor

@ocofaigh ocofaigh Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provider has a dashboard url - we should use it instead (if it works): https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/resource_instance#dashboard_url-1

Copy link
Contributor Author

@whoffler whoffler Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dashboard_url does not give us a usable URL for the resource created - 7e8ccc62-0cb0-4d57-851f-8b264699e66e.private.us-south.secrets-manager.appdomain.cloud/ui

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its producing a private endpoint url that you wont be able to hit without being logged into Global VPN. If the url construct you are doing always works lets go with that (although if the instance is in another account, the link wont work unless you switch account :( )

@ocofaigh
Copy link
Contributor

Lets also add to security enforced variation

@whoffler whoffler force-pushed the nextSteps branch 2 times, most recently from d785b73 to 9090770 Compare July 31, 2025 09:02
@knee-na
Copy link
Contributor

knee-na commented Aug 7, 2025

Update after feedback from content design: Since the Secrets Manager instance has a link out to the docs - including a link to the docs in the Next steps would be a bit much and not in line with our progressive disclosure model. Let's cut the secondary button and just include the primary button.

image

Body text:
Now, you can use Secrets Manager to manage sensitive data like passwords and API keys.

Button: Go to Secrets Manager

Go to Secrets Manager takes the user to their instance, where they see this (including a link to the docs):
image

@whoffler
Copy link
Contributor Author

whoffler commented Aug 7, 2025

/run pipeline

@whoffler
Copy link
Contributor Author

whoffler commented Aug 8, 2025

Updated:

image

@ocofaigh ocofaigh merged commit 9d7cf09 into main Aug 8, 2025
2 checks passed
@ocofaigh ocofaigh deleted the nextSteps branch August 8, 2025 19:25
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants