-
Notifications
You must be signed in to change notification settings - Fork 3
next steps #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
next steps #372
Conversation
|
/run pipeline |
|
I have 2 concerns
|
| } | ||
|
|
||
| output "next_step_primary_url" { | ||
| value = "https://cloud.ibm.com/services/secrets-manager/${local.secrets_manager_crn}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The provider has a dashboard url - we should use it instead (if it works): https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/resource_instance#dashboard_url-1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dashboard_url does not give us a usable URL for the resource created - 7e8ccc62-0cb0-4d57-851f-8b264699e66e.private.us-south.secrets-manager.appdomain.cloud/ui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its producing a private endpoint url that you wont be able to hit without being logged into Global VPN. If the url construct you are doing always works lets go with that (although if the instance is in another account, the link wont work unless you switch account :( )
|
Lets also add to security enforced variation |
d785b73 to
9090770
Compare
|
/run pipeline |
|
🎉 This PR is included in version 2.7.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |



Description
for issue - https://github.ibm.com/GoldenEye/issues/issues/13756
add next steps for user when DA is deployed successfully
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers