Skip to content

Conversation

@shemau
Copy link
Contributor

@shemau shemau commented Jul 29, 2025

Description

Update existing resources for tests to reference current code rather than an old version of module.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@shemau shemau requested a review from alex-reiff as a code owner July 29, 2025 15:20
alex-reiff
alex-reiff previously approved these changes Jul 29, 2025
@ocofaigh
Copy link
Contributor

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Jul 29, 2025

tests were showing

     pr_test.go:172: 
        	Error Trace:	/__w/terraform-ibm-secrets-manager/terraform-ibm-secrets-manager/tests/pr_test.go:172
        	Error:      	Received unexpected error:
        	            	variable [existing_event_notification_instance_crn] passed in test but not declared in variables.tf
        	Test:       	TestRunExistingResourcesInstancesFullyConfigurable
        	Messages:   	Schematic Test had unexpected error

with a series of mismatches between:
existing_event_notification_instance_crn
existing_event_notifications_instance_crn
event_notification_instance_crn
event_notifications_instance_crn

This still only impacts tests, so no release required.

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocofaigh
Copy link
Contributor

/run pipeline

@ocofaigh ocofaigh merged commit d1341bd into main Jul 30, 2025
2 checks passed
@ocofaigh ocofaigh deleted the dep-loop branch July 30, 2025 10:28
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.6.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants