feat: add two new service roles

[jor2]

Description

#425

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[jor2]

/run pipeline

[ocofaigh]

Im expecting upgrade test to fail as it will want to update the auth policy. Once it updates, as opposed to destroys / re-creates, its safe to skip

[ocofaigh]

@jor2 you need to bump the test wrapper for addons fix

[jor2]

/run pipeline

[jor2]

/run pipeline

[ocofaigh]

There was a bug in the test which I pushed a fix for. re-running..

[ocofaigh]

/run pipeline

[ocofaigh]

@jor2 You need to skip the upgrade test. This is an update in place and expected, so safe to skip..

        	Messages:   	Resource(s) identified to be updated 
        	            	Name: iam_identity_policy
        	            	Address: module.secrets_manager.module.secrets_manager.ibm_iam_authorization_policy.iam_identity_policy[0]
        	            	Actions: [update]
        	            	DIFF:
        	            	  Before: 
        	            		{"description":"Allows Secrets Manager instance dde9d8d7-0a37-4c31-a3cb-0d54c9b2e885 `Operator` access to the IAM Identity service to enable creating IAM credentials.","roles":"SECURE_VALUE_HIDDEN_HASH:-a61e9a8ffac694e1beff22f79c8445e563a8622b20c417c0133f32bf"}
        	            	  After: 
        	            		{"description":"Allows Secrets Manager instance dde9d8d7-0a37-4c31-a3cb-0d54c9b2e885 access to the IAM Identity service to enable creating IAM credentials.","roles":"SECURE_VALUE_HIDDEN_HASH:-f69404ba44ac8ee69a7230748679d59c2da072aaeb2eaf42a4d23d74"}

[jor2]

/run pipeline

[jor2]

/run pipeline

[jor2]

/run pipeline

[ocofaigh]

@jor2 you need to resolve conflicts first

[jor2]

/run pipeline

[jor2]

/run pipeline

[jor2]

=== NAME  TestAddonsExistingSecretsManager
    setup_teardown.go:513: 
        	Error Trace:	/go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.60.13/testaddons/setup_teardown.go:513
        	            				/go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.60.13/testaddons/setup_teardown.go:451
        	            				/usr/local/go/src/runtime/asm_amd64.s:1693
        	Error:      	Received unexpected error:
        	            	failed after 5 attempts: This project cannot be deleted because there is at least one configuration running a pipeline action. Try again after the following configurations are done their pipeline actions: extsm-qvu-deploy-arch-ibm-secrets-manager(8ce40b73-a194-4435-aefd-c0de25fe787c)
        	Test:       	TestAddonsExistingSecretsManager
[TestAddonsExistingSecretsManager] TEST EXECUTION END: TestAddonsExistingSecretsManager - RESULT: PASSED
--- FAIL: TestAddonsExistingSecretsManager (2993.00s)

[shemau]

I have bumped up to test wrapper 1.60.15 and also common-dev-assets in a renovate related change (#430) which are newer than the versions in this PR. So it should be appropriate to remove them from here.

[jor2]

/run pipeline

[terraform-ibm-modules-ops]

🎉 This PR is included in version 2.11.2 🎉

The release is available on:

• GitHub release
• v2.11.2

Your semantic-release bot 📦🚀