From b0e918df4a263345ff60330dd850ee0be7d5c89a Mon Sep 17 00:00:00 2001 From: Alex Reiff Date: Tue, 18 Mar 2025 22:37:42 -0400 Subject: [PATCH 1/2] test: move kms tests off EU --- tests/other_test.go | 6 ++++++ tests/pr_test.go | 6 +++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/tests/other_test.go b/tests/other_test.go index ee1f0a4c..81139f14 100644 --- a/tests/other_test.go +++ b/tests/other_test.go @@ -12,6 +12,12 @@ import ( func TestRunBasicExample(t *testing.T) { t.Parallel() + var validRegions = []string{ + "eu-de", + "eu-gb", + "au-syd", + } + options := testhelper.TestOptionsDefaultWithVars(&testhelper.TestOptions{ Testing: t, TerraformDir: "examples/basic", diff --git a/tests/pr_test.go b/tests/pr_test.go index 0e4e6459..eaf7ee32 100644 --- a/tests/pr_test.go +++ b/tests/pr_test.go @@ -36,9 +36,9 @@ var permanentResources map[string]interface{} // Current supported Event Notification regions var validRegions = []string{ // "us-south", # do not run secrets manager tests in us regions - "eu-de", - "eu-gb", - "au-syd", + // "eu-de", + // "eu-gb", + "au-syd", // all tests using KMS should avoid dallas and EU regions https://github.ibm.com/GoldenEye/issues/issues/12725 } // TestMain will be run before any parallel tests, used to read data from yaml for use with tests From b65ee6e6d124f7ada888d6607ae0ad0f4d1f332e Mon Sep 17 00:00:00 2001 From: Alex Reiff Date: Wed, 19 Mar 2025 11:00:50 -0400 Subject: [PATCH 2/2] test: change example defaults --- examples/complete/README.md | 2 +- examples/complete/variables.tf | 2 +- examples/fscloud/variables.tf | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/complete/README.md b/examples/complete/README.md index e2e7bb2e..a2cfccc7 100644 --- a/examples/complete/README.md +++ b/examples/complete/README.md @@ -34,7 +34,7 @@ This examples handles the provisioning of a new Secrets Manager instance. | [en\_region](#input\_en\_region) | Region where event notification will be created | `string` | `"au-syd"` | no | | [ibmcloud\_api\_key](#input\_ibmcloud\_api\_key) | The IBM Cloud API key this account authenticates to | `string` | n/a | yes | | [prefix](#input\_prefix) | Prefix for sm instance | `string` | `"sm-com"` | no | -| [region](#input\_region) | Region where resources will be created | `string` | `"us-east"` | no | +| [region](#input\_region) | Region where resources will be created | `string` | `"au-syd"` | no | | [resource\_group](#input\_resource\_group) | An existing resource group name to use for this example, if unset a new resource group will be created | `string` | `null` | no | | [resource\_tags](#input\_resource\_tags) | Optional list of tags to be added to created resources | `list(string)` | `[]` | no | | [sm\_service\_plan](#input\_sm\_service\_plan) | The Secrets Manager service plan to provision | `string` | `"trial"` | no | diff --git a/examples/complete/variables.tf b/examples/complete/variables.tf index 69577ea4..09fd34cd 100644 --- a/examples/complete/variables.tf +++ b/examples/complete/variables.tf @@ -18,7 +18,7 @@ variable "sm_service_plan" { variable "region" { type = string description = "Region where resources will be created" - default = "us-east" + default = "au-syd" } variable "resource_group" { diff --git a/examples/fscloud/variables.tf b/examples/fscloud/variables.tf index fc1b8e37..7bd97882 100644 --- a/examples/fscloud/variables.tf +++ b/examples/fscloud/variables.tf @@ -13,7 +13,7 @@ variable "prefix" { variable "region" { type = string description = "Region where resources will be created" - default = "us-south" + default = "au-syd" } variable "resource_group" {