Skip to content

Conversation

@rajatagarwal-ibm
Copy link
Member

@rajatagarwal-ibm rajatagarwal-ibm commented Jul 16, 2025

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@rajatagarwal-ibm
Copy link
Member Author

TODO: Need to bump Event Notification version once EN PR is merged.

@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

alex-reiff
alex-reiff previously approved these changes Aug 6, 2025
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Activity tracker and Cloud Logs is missing from dependencies. I also think we should wait for new EN version after terraform-ibm-modules/terraform-ibm-event-notifications#489 is merged - Im pushing to get that PR in asap

…ules/terraform-ibm-secrets-manager into split-observability-da
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These still reference old Observability DA:
image

And your missing Cloud Logs DA still

@rajatagarwal-ibm
Copy link
Member Author

EN dependency PR is merged terraform-ibm-modules/terraform-ibm-event-notifications#524, I have updated code to consume latest EN and test wrapper version.

@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

{
"name": "deploy-arch-ibm-observability",
"description": "Enables provisioning and configuration of IBM Cloud Logs to collect, route, analyze, and visualize platform logs and events — including those generated by the Event Notifications instance — for enhanced visibility, alerting, and troubleshooting.",
"name": "deploy-arch-ibm-cloud-logs",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just started looking at doing this for Event Streams does Cloud Logs have a dependency on COS?

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think yes, Cloud Logs have dependency on COS

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so COS is automatically added as an addon because it is a dependency of an enabled addon

When COS is disabled the user would have to supply the existing_cos_instance_crn themselves... got it, thanks

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the following:

  • KMS v5.1.19
  • EN v2.6.11
  • Cloud Mon v1.6.4
  • Cloud Logs v1.6.11
  • AT v1.2.11 v1.2.12

@maheshwarishikha
Copy link
Member

@rajatagarwal-ibm when are you planning to complete this one? OCP DA is dependent on SM DA.

@rajatagarwal-ibm
Copy link
Member Author

@maheshwarishikha thanks for checking in. As far as I remember someone from India team was working on some dependency of SM last week. I didn't get a chance to look if that's completed or not.

@ocofaigh
Copy link
Contributor

@rajatagarwal-ibm The dependency was fixed in terraform-ibm-modules/terraform-ibm-activity-tracker#77 2 weeks ago. Please use Activity Tracker version v1.2.12

@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

@rajatagarwal-ibm
Copy link
Member Author

@ocofaigh yes as per our discussion in the scrum, all the changes were already in. Re-ran the pipeline

@ocofaigh ocofaigh merged commit aaa66f6 into main Aug 25, 2025
2 checks passed
@ocofaigh ocofaigh deleted the split-observability-da branch August 25, 2025 11:09
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants