From b62463b86bf76adf38835e63f7654392681374f0 Mon Sep 17 00:00:00 2001 From: whoffler Date: Thu, 24 Jul 2025 14:05:03 +0100 Subject: [PATCH 1/6] next steps --- solutions/fully-configurable/outputs.tf | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/solutions/fully-configurable/outputs.tf b/solutions/fully-configurable/outputs.tf index 52332205..765dcaa7 100644 --- a/solutions/fully-configurable/outputs.tf +++ b/solutions/fully-configurable/outputs.tf @@ -32,3 +32,18 @@ output "secrets_manager_region" { value = local.secrets_manager_region description = "Region of the Secrets Manager instance" } + +output "next_steps_text" { + value = "Congragulations! You successfully deployed your changes. Next, view your Secrets Manager instance: ${var.existing_secrets_manager_crn == null ? module.secrets_manager.secrets_manager_name : data.ibm_resource_instance.existing_sm[0].resource_name}" + description = "Next steps text" +} + +output "next_step_primary_label" { + value = "SM Instance" + description = "Primary label" +} + +output "next_step_primary_url" { + value = "https://cloud.ibm.com/services/secrets-manager/${local.secrets_manager_crn}" + description = "primary url" +} From 198833f586521742f038bf8e1b911e28ab578267 Mon Sep 17 00:00:00 2001 From: whoffler Date: Thu, 24 Jul 2025 14:34:27 +0100 Subject: [PATCH 2/6] Clean text, update button text --- solutions/fully-configurable/outputs.tf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/solutions/fully-configurable/outputs.tf b/solutions/fully-configurable/outputs.tf index 765dcaa7..d52ada6e 100644 --- a/solutions/fully-configurable/outputs.tf +++ b/solutions/fully-configurable/outputs.tf @@ -34,12 +34,12 @@ output "secrets_manager_region" { } output "next_steps_text" { - value = "Congragulations! You successfully deployed your changes. Next, view your Secrets Manager instance: ${var.existing_secrets_manager_crn == null ? module.secrets_manager.secrets_manager_name : data.ibm_resource_instance.existing_sm[0].resource_name}" + value = "Congragulations! You successfully deployed your changes. Next, view your Secrets Manager instance." description = "Next steps text" } output "next_step_primary_label" { - value = "SM Instance" + value = "View Secrets Manager" description = "Primary label" } From 821e263cd95a8fa36272e5030d0805e6e296ddb6 Mon Sep 17 00:00:00 2001 From: whoffler Date: Thu, 24 Jul 2025 15:49:08 +0100 Subject: [PATCH 3/6] fix typo --- solutions/fully-configurable/outputs.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/solutions/fully-configurable/outputs.tf b/solutions/fully-configurable/outputs.tf index d52ada6e..7e6a3e90 100644 --- a/solutions/fully-configurable/outputs.tf +++ b/solutions/fully-configurable/outputs.tf @@ -34,7 +34,7 @@ output "secrets_manager_region" { } output "next_steps_text" { - value = "Congragulations! You successfully deployed your changes. Next, view your Secrets Manager instance." + value = "Congratulations! You successfully deployed your changes. Next, view your Secrets Manager instance." description = "Next steps text" } From 2086f4070fe89adca8ce7de57cda297750365f2b Mon Sep 17 00:00:00 2001 From: whoffler Date: Fri, 25 Jul 2025 15:46:02 +0100 Subject: [PATCH 4/6] added to sec enforced, added secondary link --- README.md | 1 + outputs.tf | 5 +++++ solutions/fully-configurable/outputs.tf | 20 ++++++++++++++++++-- solutions/security-enforced/README.md | 2 +- solutions/security-enforced/outputs.tf | 25 +++++++++++++++++++++++++ 5 files changed, 50 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 7c9ec336..eaeebc1e 100644 --- a/README.md +++ b/README.md @@ -121,6 +121,7 @@ You need the following permissions to run this module. | [secret\_groups](#output\_secret\_groups) | IDs of the created Secret Group | | [secrets](#output\_secrets) | List of secret mananger secret config data | | [secrets\_manager\_crn](#output\_secrets\_manager\_crn) | CRN of the Secrets Manager instance | +| [secrets\_manager\_dashboard\_url](#output\_secrets\_manager\_dashboard\_url) | Secrets Manager dashboard url. | | [secrets\_manager\_guid](#output\_secrets\_manager\_guid) | GUID of Secrets Manager instance | | [secrets\_manager\_id](#output\_secrets\_manager\_id) | ID of the Secrets Manager instance | | [secrets\_manager\_name](#output\_secrets\_manager\_name) | Name of the Secrets Manager instance | diff --git a/outputs.tf b/outputs.tf index 769d593e..f20eab06 100644 --- a/outputs.tf +++ b/outputs.tf @@ -37,4 +37,9 @@ output "secrets" { value = module.secrets.secrets description = "List of secret mananger secret config data" } + +output "secrets_manager_dashboard_url" { + description = "Secrets Manager dashboard url." + value = var.existing_sm_instance_crn != null ? "" : ibm_resource_instance.secrets_manager_instance[0].dashboard_url +} ############################################################################## diff --git a/solutions/fully-configurable/outputs.tf b/solutions/fully-configurable/outputs.tf index 7e6a3e90..3149cb73 100644 --- a/solutions/fully-configurable/outputs.tf +++ b/solutions/fully-configurable/outputs.tf @@ -34,7 +34,7 @@ output "secrets_manager_region" { } output "next_steps_text" { - value = "Congratulations! You successfully deployed your changes. Next, view your Secrets Manager instance." + value = "Congratulations! Click the link below to go your Secrets Manager instance. Refer to this deployment guide/documentation for more information." description = "Next steps text" } @@ -43,7 +43,23 @@ output "next_step_primary_label" { description = "Primary label" } + +output "secrets_manager_dashboard_url" { + description = "Secrets Manager dashboard url." + value = var.existing_secrets_manager_crn != null ? "" : module.secrets_manager.secrets_manager_dashboard_url +} + output "next_step_primary_url" { - value = "https://cloud.ibm.com/services/secrets-manager/${local.secrets_manager_crn}" + value = module.secrets_manager.secrets_manager_dashboard_url description = "primary url" } + +output "next_step_secondary_label" { + value = "Check out related Deployable Architectures" + description = "Secondary label" +} + +output "next_step_secondary_url" { + value = "https://cloud.ibm.com/catalog?search=Secrets%20Manager%20label%3Adeployable_architecture#search_results" + description = "Secondary url" +} diff --git a/solutions/security-enforced/README.md b/solutions/security-enforced/README.md index 0d770daf..c9385c05 100644 --- a/solutions/security-enforced/README.md +++ b/solutions/security-enforced/README.md @@ -1,3 +1,3 @@ # Cloud automation for Secrets Manager (Security enforced) -:exclamation: **Important:** This solution is not intended to be called by other modules because it contains a provider configuration and is not compatible with the `for_each`, `count`, and `depends_on` arguments. For more information, see [Providers Within Modules](https://developer.hashicorp.com/terraform/language/modules/develop/providers). +:exclamation: **Important:** This solution is not intended to be called by other modules because it contains a provider configuration and is not compatible with the `for_each`, `count`, and `depends_on` arguments. For more information, see [Providers Within Modules](https://developer.hashicorp.com/terraform/language/modules/develop/providers). \ No newline at end of file diff --git a/solutions/security-enforced/outputs.tf b/solutions/security-enforced/outputs.tf index d10dfacc..815a0b2e 100644 --- a/solutions/security-enforced/outputs.tf +++ b/solutions/security-enforced/outputs.tf @@ -22,3 +22,28 @@ output "secrets_manager_crn" { description = "CRN of Secrets Manager instance." value = module.secrets_manager.secrets_manager_crn } + +output "next_steps_text" { + value = "Congratulations! Click the link below to go your Secrets Manager instance. Refer to this deployment guide/documentation for more information." + description = "Next steps text" +} + +output "next_step_primary_label" { + value = "View Secrets Manager" + description = "Primary label" +} + +output "next_step_primary_url" { + value = module.secrets_manager.secrets_manager_dashboard_url + description = "primary url" +} + +output "next_step_secondary_label" { + value = "Check out related Deployable Architectures" + description = "Secondary label" +} + +output "next_step_secondary_url" { + value = "https://cloud.ibm.com/catalog?search=Secrets%20Manager%20label%3Adeployable_architecture#search_results" + description = "Secondary url" +} From b008de2455931342554f86d27417a2fc0d7854c2 Mon Sep 17 00:00:00 2001 From: whoffler Date: Mon, 28 Jul 2025 10:07:37 +0100 Subject: [PATCH 5/6] remove dashboard_url output --- README.md | 1 - outputs.tf | 5 ----- solutions/fully-configurable/outputs.tf | 8 +------- solutions/security-enforced/outputs.tf | 4 ++-- 4 files changed, 3 insertions(+), 15 deletions(-) diff --git a/README.md b/README.md index eaeebc1e..7c9ec336 100644 --- a/README.md +++ b/README.md @@ -121,7 +121,6 @@ You need the following permissions to run this module. | [secret\_groups](#output\_secret\_groups) | IDs of the created Secret Group | | [secrets](#output\_secrets) | List of secret mananger secret config data | | [secrets\_manager\_crn](#output\_secrets\_manager\_crn) | CRN of the Secrets Manager instance | -| [secrets\_manager\_dashboard\_url](#output\_secrets\_manager\_dashboard\_url) | Secrets Manager dashboard url. | | [secrets\_manager\_guid](#output\_secrets\_manager\_guid) | GUID of Secrets Manager instance | | [secrets\_manager\_id](#output\_secrets\_manager\_id) | ID of the Secrets Manager instance | | [secrets\_manager\_name](#output\_secrets\_manager\_name) | Name of the Secrets Manager instance | diff --git a/outputs.tf b/outputs.tf index f20eab06..769d593e 100644 --- a/outputs.tf +++ b/outputs.tf @@ -37,9 +37,4 @@ output "secrets" { value = module.secrets.secrets description = "List of secret mananger secret config data" } - -output "secrets_manager_dashboard_url" { - description = "Secrets Manager dashboard url." - value = var.existing_sm_instance_crn != null ? "" : ibm_resource_instance.secrets_manager_instance[0].dashboard_url -} ############################################################################## diff --git a/solutions/fully-configurable/outputs.tf b/solutions/fully-configurable/outputs.tf index 3149cb73..46268d5f 100644 --- a/solutions/fully-configurable/outputs.tf +++ b/solutions/fully-configurable/outputs.tf @@ -43,14 +43,8 @@ output "next_step_primary_label" { description = "Primary label" } - -output "secrets_manager_dashboard_url" { - description = "Secrets Manager dashboard url." - value = var.existing_secrets_manager_crn != null ? "" : module.secrets_manager.secrets_manager_dashboard_url -} - output "next_step_primary_url" { - value = module.secrets_manager.secrets_manager_dashboard_url + value = "https://cloud.ibm.com/services/secrets-manager/${local.secrets_manager_crn}" description = "primary url" } diff --git a/solutions/security-enforced/outputs.tf b/solutions/security-enforced/outputs.tf index 815a0b2e..47511323 100644 --- a/solutions/security-enforced/outputs.tf +++ b/solutions/security-enforced/outputs.tf @@ -24,7 +24,7 @@ output "secrets_manager_crn" { } output "next_steps_text" { - value = "Congratulations! Click the link below to go your Secrets Manager instance. Refer to this deployment guide/documentation for more information." + value = "Congratulations! Click the link below to go your Secrets Manager instance. Refer to this deployment's guide/documentation for more information." description = "Next steps text" } @@ -34,7 +34,7 @@ output "next_step_primary_label" { } output "next_step_primary_url" { - value = module.secrets_manager.secrets_manager_dashboard_url + value = "https://cloud.ibm.com/services/secrets-manager/${module.secrets_manager.secrets_manager_crn}" description = "primary url" } From 9a4504071d6a186909b0c97397790e47f07d7155 Mon Sep 17 00:00:00 2001 From: whoffler Date: Thu, 7 Aug 2025 15:58:42 +0100 Subject: [PATCH 6/6] align next steps with content design feedback --- solutions/fully-configurable/outputs.tf | 14 ++------------ solutions/security-enforced/README.md | 2 +- solutions/security-enforced/outputs.tf | 14 ++------------ 3 files changed, 5 insertions(+), 25 deletions(-) diff --git a/solutions/fully-configurable/outputs.tf b/solutions/fully-configurable/outputs.tf index 46268d5f..37bec90c 100644 --- a/solutions/fully-configurable/outputs.tf +++ b/solutions/fully-configurable/outputs.tf @@ -34,12 +34,12 @@ output "secrets_manager_region" { } output "next_steps_text" { - value = "Congratulations! Click the link below to go your Secrets Manager instance. Refer to this deployment guide/documentation for more information." + value = "Now, you can use Secrets Manager to manage sensitive data like passwords and API keys." description = "Next steps text" } output "next_step_primary_label" { - value = "View Secrets Manager" + value = "Go to Secrets Manager" description = "Primary label" } @@ -47,13 +47,3 @@ output "next_step_primary_url" { value = "https://cloud.ibm.com/services/secrets-manager/${local.secrets_manager_crn}" description = "primary url" } - -output "next_step_secondary_label" { - value = "Check out related Deployable Architectures" - description = "Secondary label" -} - -output "next_step_secondary_url" { - value = "https://cloud.ibm.com/catalog?search=Secrets%20Manager%20label%3Adeployable_architecture#search_results" - description = "Secondary url" -} diff --git a/solutions/security-enforced/README.md b/solutions/security-enforced/README.md index c9385c05..0d770daf 100644 --- a/solutions/security-enforced/README.md +++ b/solutions/security-enforced/README.md @@ -1,3 +1,3 @@ # Cloud automation for Secrets Manager (Security enforced) -:exclamation: **Important:** This solution is not intended to be called by other modules because it contains a provider configuration and is not compatible with the `for_each`, `count`, and `depends_on` arguments. For more information, see [Providers Within Modules](https://developer.hashicorp.com/terraform/language/modules/develop/providers). \ No newline at end of file +:exclamation: **Important:** This solution is not intended to be called by other modules because it contains a provider configuration and is not compatible with the `for_each`, `count`, and `depends_on` arguments. For more information, see [Providers Within Modules](https://developer.hashicorp.com/terraform/language/modules/develop/providers). diff --git a/solutions/security-enforced/outputs.tf b/solutions/security-enforced/outputs.tf index 47511323..01ae5c1d 100644 --- a/solutions/security-enforced/outputs.tf +++ b/solutions/security-enforced/outputs.tf @@ -24,12 +24,12 @@ output "secrets_manager_crn" { } output "next_steps_text" { - value = "Congratulations! Click the link below to go your Secrets Manager instance. Refer to this deployment's guide/documentation for more information." + value = "Now, you can use Secrets Manager to manage sensitive data like passwords and API keys." description = "Next steps text" } output "next_step_primary_label" { - value = "View Secrets Manager" + value = "Go to Secrets Manager" description = "Primary label" } @@ -37,13 +37,3 @@ output "next_step_primary_url" { value = "https://cloud.ibm.com/services/secrets-manager/${module.secrets_manager.secrets_manager_crn}" description = "primary url" } - -output "next_step_secondary_label" { - value = "Check out related Deployable Architectures" - description = "Secondary label" -} - -output "next_step_secondary_url" { - value = "https://cloud.ibm.com/catalog?search=Secrets%20Manager%20label%3Adeployable_architecture#search_results" - description = "Secondary url" -}