Skip to content

remove unused variables in test #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 3, 2025
Merged

remove unused variables in test #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c1843ba
remove unused variables in test
alex-reiff Aug 25, 2025
494c629
Merge branch 'main' into 15572
alex-reiff Aug 27, 2025
f0b31f6
bump test wrapper
alex-reiff Aug 27, 2025
9a046e2
bump test wrapper
alex-reiff Aug 27, 2025
c327c09
Merge branch 'main' into 15572
alex-reiff Sep 2, 2025
c3a2d05
readme
alex-reiff Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion modules/fscloud/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ module "secrets_manager" {
resource_group_id = "xxXXxxXXxXxXXXXxxXxxxXXXXxXXXXX"
region = "us-south"
secrets_manager_name = "my-secrets-manager"
existing_kms_instance_guid = var.existing_kms_instance_guid
kms_key_crn = var.kms_key_crn
}
```
Expand Down
2 changes: 0 additions & 2 deletions tests/other_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,7 @@ func TestFSCloudInSchematics(t *testing.T) {
{Name: "ibmcloud_api_key", Value: options.RequiredEnvironmentVars["TF_VAR_ibmcloud_api_key"], DataType: "string", Secure: true},
{Name: "region", Value: validRegions[rand.Intn(len(validRegions))], DataType: "string"},
{Name: "prefix", Value: options.Prefix, DataType: "string"},
{Name: "existing_kms_instance_guid", Value: permanentResources["hpcs_south"], DataType: "string"},
{Name: "kms_key_crn", Value: permanentResources["hpcs_south_root_key_crn"], DataType: "string"},
{Name: "sm_service_plan", Value: "trial", DataType: "string"},
Copy link
Contributor

@shemau shemau Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changed from sm_service_plan to service_plan in variables.tf. For testing should it be setting the service_plan to trial?

Copy link
Contributor Author

@alex-reiff alex-reiff Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shemau
service_plan is not exposed in the fscloud example. It's been this way since: #53

}

err := options.RunSchematicTest()
Expand Down