Removes inbound ping from default security group (#33)

Addresses #22

Signed-off-by: Sean Sundberg <[email protected]>

Author: Sean Sundberg

main.tf

@@ -60,17 +60,6 @@ resource null_resource post_vpc_address_pfx_default {
   }
 }
 
-resource ibm_is_security_group_rule rule_icmp_ping {
-  count = var.provision ? 1 : 0
-
-  group     = local.security_group_id
-  direction = "inbound"
-  remote    = "0.0.0.0/0"
-  icmp {
-    type = 8
-  }
-}
-
 # from https://cloud.ibm.com/docs/vpc?topic=vpc-service-endpoints-for-vpc
 resource ibm_is_security_group_rule "cse_dns_1" {
   count = var.provision ? 1 : 0

test/stages/stage2-vpc.tf

@@ -1,11 +1,11 @@
 module "dev_vpc" {
   source = "./module"
 
-  resource_group_id   = module.resource_group.id
-  resource_group_name = module.resource_group.name
-  region              = var.region
-  name_prefix         = var.name_prefix
-  ibmcloud_api_key    = var.ibmcloud_api_key
+  resource_group_id    = module.resource_group.id
+  resource_group_name  = module.resource_group.name
+  region               = var.region
+  name_prefix          = var.name_prefix
+  ibmcloud_api_key     = var.ibmcloud_api_key
   address_prefix_count = var.address_prefix_count
-  address_prefixes = tolist(setsubtract(split(",", var.address_prefixes), [""]))
+  address_prefixes     = jsondecode(var.address_prefixes)
 }

test/stages/variables.tf

@@ -51,7 +51,7 @@ variable "vpc_subnets" {
 }
 
 variable "address_prefixes" {
-  default = ""
+  default = "[]"
 }
 
 variable "address_prefix_count" {