generated from terraform-ibm-modules/terraform-ibm-module-template
    
        
        - 
                Notifications
    
You must be signed in to change notification settings  - Fork 0
 
tests: use existing resources and test DA directly #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    argeiger
  
              
              previously approved these changes
              
                  
                    Feb 12, 2025 
                  
              
              
            
            
| 
           /run pipeline  | 
    
| 
           /run pipeline  | 
    
| 
           /run pipeline  | 
    
| 
           /run pipeline  | 
    
    
      
        1 similar comment
      
    
  
    | 
           /run pipeline  | 
    
| 
           /run pipeline  | 
    
              
                    ocofaigh
  
              
              approved these changes
              
                  
                    Apr 28, 2025 
                  
              
              
            
            
| 
           🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀  | 
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description
The code in https://github.com/terraform-ibm-modules/terraform-ibm-cloudpak-data is only a DA (no module). The DA contains a provider configuration and is not compatible with the for_each, count, and depends_on arguments, hence should not be consumed the way it is in the basic example. So we should remove the basic example and instead update the tests to directly test the DA code.
To do this, we will need to have code in the tests folder to provision the pre-req cluster (same way we do in other DA tests when working with existing resources).
I also notice the DA is not locked into exact provider versions. We should lock into an exact version to ensure consistency.
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers