Skip to content

Conversation

@argeiger
Copy link
Contributor

@argeiger argeiger commented Dec 11, 2024

Description

Initial commit of repository for the creation of a deployable architecture to provision cloudpak for data within an OpenShift cluster

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@argeiger
Copy link
Contributor Author

/run pipeline

17 similar comments
@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

@argeiger
Copy link
Contributor Author

/run pipeline

Copy link
Member

@vburckhardt vburckhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Adam, some comments inline.

},
IgnoreUpdates: testhelper.Exemptions{ // Ignore for consistency check
List: []string{
"module.cloudpak_data.module.cloud_pak_deployer.kubernetes_namespace_v1.cloud_pak_deployer_namespace",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may just want to track those for resolution as they will show up in project's drift report

##############################################################################
# Code engine resources
##############################################################################
resource "ibm_code_engine_project" "ce_project" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly consider using https://github.com/terraform-ibm-modules/terraform-ibm-code-engine.

The DA should also allow using an existing code engine project to facilitate stack assembly in project

}
}

resource "terraform_data" "uninstall_cpd" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could the shell provider be used here to improve lifecycle handling? https://github.com/terraform-ibm-modules/terraform-provider-shell

provisioner "local-exec" {
when = destroy
command = <<EOF
#!/bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scripts should be in their own file so that they get through the various pipeline checks (lint, shellcheck)

@argeiger
Copy link
Contributor Author

argeiger commented Jan 8, 2025

/run pipeline

@argeiger
Copy link
Contributor Author

argeiger commented Jan 8, 2025

/run pipeline

@vburckhardt vburckhardt self-requested a review January 9, 2025 10:10
@vburckhardt vburckhardt merged commit 1347f11 into main Jan 9, 2025
2 checks passed
@vburckhardt vburckhardt deleted the init branch January 9, 2025 10:10
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants