-
Notifications
You must be signed in to change notification settings - Fork 0
initial commit #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
17 similar comments
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Adam, some comments inline.
| }, | ||
| IgnoreUpdates: testhelper.Exemptions{ // Ignore for consistency check | ||
| List: []string{ | ||
| "module.cloudpak_data.module.cloud_pak_deployer.kubernetes_namespace_v1.cloud_pak_deployer_namespace", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we may just want to track those for resolution as they will show up in project's drift report
| ############################################################################## | ||
| # Code engine resources | ||
| ############################################################################## | ||
| resource "ibm_code_engine_project" "ce_project" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly consider using https://github.com/terraform-ibm-modules/terraform-ibm-code-engine.
The DA should also allow using an existing code engine project to facilitate stack assembly in project
| } | ||
| } | ||
|
|
||
| resource "terraform_data" "uninstall_cpd" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could the shell provider be used here to improve lifecycle handling? https://github.com/terraform-ibm-modules/terraform-provider-shell
| provisioner "local-exec" { | ||
| when = destroy | ||
| command = <<EOF | ||
| #!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scripts should be in their own file so that they get through the various pipeline checks (lint, shellcheck)
|
/run pipeline |
|
/run pipeline |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Initial commit of repository for the creation of a deployable architecture to provision cloudpak for data within an OpenShift cluster
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers