-
Couldn't load subscription status.
- Fork 0
feat: region dropdown in ibm_catalog #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
| { | ||
| "key": "region" | ||
| "key": "region", | ||
| "options": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should Osaka jp-osa also be an option here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it should. As per the var description, the region here is: "Region where Code Engine and Container Registry resources will be provisioned." jp-osa is a supported code engine region - @kierramarie please review the regions used here against the services
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I will add Osaka. Also, Montreal is supported in Code Engine and not in container registry and us-east is supported in CR and not in CE. How would you like me address those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest Im not too worried here, as by default the DA will not create a code engine project or container registry namespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments - the list of region is not accurate it seems
|
/run pipeline |
|
🎉 This PR is included in version 2.0.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Updated region variable in ibm_catalog.json to use a dropdown.
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers