Skip to content

Conversation

@kierramarie
Copy link
Member

Description

Updated region variable in ibm_catalog.json to use a dropdown.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@kierramarie kierramarie requested a review from argeiger as a code owner August 7, 2025 19:08
@kierramarie
Copy link
Member Author

/run pipeline

argeiger
argeiger previously approved these changes Aug 7, 2025
{
"key": "region"
"key": "region",
"options": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Osaka jp-osa also be an option here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it should. As per the var description, the region here is: "Region where Code Engine and Container Registry resources will be provisioned." jp-osa is a supported code engine region - @kierramarie please review the regions used here against the services

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will add Osaka. Also, Montreal is supported in Code Engine and not in container registry and us-east is supported in CR and not in CE. How would you like me address those?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@ocofaigh ocofaigh Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest Im not too worried here, as by default the DA will not create a code engine project or container registry namespace.

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments - the list of region is not accurate it seems

@kierramarie
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit 72ea4d0 into main Sep 16, 2025
2 checks passed
@ocofaigh ocofaigh deleted the ks-catalog-region branch September 16, 2025 20:41
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants