Skip to content

Commit 851ba2c

Browse files
committed
tflint: Allow to omit metadata expr on EmitIssue
1 parent 8fecf1a commit 851ba2c

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

tflint/client.go

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -206,18 +206,21 @@ type EmitIssueRequest struct {
206206
// Note that the passed rule need to be converted to generic objects
207207
// because the custom structure defined in the plugin cannot be sent via RPC.
208208
func (c *Client) EmitIssue(rule Rule, message string, location hcl.Range, meta Metadata) error {
209-
src, err := ioutil.ReadFile(meta.Expr.Range().Filename)
210-
if err != nil {
211-
return err
209+
req := &EmitIssueRequest{
210+
Rule: newObjectFromRule(rule),
211+
Message: message,
212+
Location: location,
212213
}
213214

214-
req := &EmitIssueRequest{
215-
Rule: newObjectFromRule(rule),
216-
Message: message,
217-
Location: location,
218-
Expr: meta.Expr.Range().SliceBytes(src),
219-
ExprRange: meta.Expr.Range(),
215+
if meta.Expr != nil {
216+
src, err := ioutil.ReadFile(meta.Expr.Range().Filename)
217+
if err != nil {
218+
return err
219+
}
220+
req.Expr = meta.Expr.Range().SliceBytes(src)
221+
req.ExprRange = meta.Expr.Range()
220222
}
223+
221224
if err := c.rpcClient.Call("Plugin.EmitIssue", &req, new(interface{})); err != nil {
222225
return err
223226
}

0 commit comments

Comments
 (0)