Skip to content

Commit e305c29

Browse files
authored
tflint: Make sure RuleNames always return all rules (#100)
1 parent cf013ac commit e305c29

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

tflint/ruleset.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ type BuiltinRuleSet struct {
1111
Name string
1212
Version string
1313
Rules []Rule
14+
15+
EnabledRules []Rule
1416
}
1517

1618
// RuleSetName is the name of the ruleset.
@@ -42,7 +44,7 @@ func (r *BuiltinRuleSet) ApplyConfig(config *Config) error {
4244

4345
// ApplyCommonConfig reflects common configurations regardless of plugins.
4446
func (r *BuiltinRuleSet) ApplyCommonConfig(config *Config) {
45-
rules := []Rule{}
47+
r.EnabledRules = []Rule{}
4648

4749
if config.DisabledByDefault {
4850
log.Printf("[DEBUG] Only mode is enabled. Ignoring default plugin rules")
@@ -57,15 +59,14 @@ func (r *BuiltinRuleSet) ApplyCommonConfig(config *Config) {
5759
}
5860

5961
if enabled {
60-
rules = append(rules, rule)
62+
r.EnabledRules = append(r.EnabledRules, rule)
6163
}
6264
}
63-
r.Rules = rules
6465
}
6566

6667
// Check runs inspection for each rule by applying Runner.
6768
func (r *BuiltinRuleSet) Check(runner Runner) error {
68-
for _, rule := range r.Rules {
69+
for _, rule := range r.EnabledRules {
6970
if err := rule.Check(runner); err != nil {
7071
return fmt.Errorf("Failed to check `%s` rule: %s", rule.Name(), err)
7172
}

0 commit comments

Comments
 (0)