Skip to content

Commit 327b223

Browse files
authored
Remove aws_cognito_user_pool_domain_invalid_domain rule (#158)
1 parent ed113a4 commit 327b223

File tree

5 files changed

+1
-146
lines changed

5 files changed

+1
-146
lines changed

docs/rules/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,6 @@ These rules enforce best practices and naming conventions:
231231
|aws_cognito_user_pool_client_invalid_name||
232232
|aws_cognito_user_pool_client_invalid_user_pool_id||
233233
|aws_cognito_user_pool_domain_invalid_certificate_arn||
234-
|aws_cognito_user_pool_domain_invalid_domain||
235234
|aws_cognito_user_pool_domain_invalid_user_pool_id||
236235
|aws_cognito_user_pool_invalid_email_verification_message||
237236
|aws_cognito_user_pool_invalid_email_verification_subject||

rules/models/aws_cognito_user_pool_domain_invalid_domain.go

Lines changed: 0 additions & 87 deletions
This file was deleted.

rules/models/aws_cognito_user_pool_domain_invalid_domain_test.go

Lines changed: 0 additions & 51 deletions
This file was deleted.

rules/models/mappings/cognito-idp.hcl

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ mapping "aws_cognito_user_pool_client" {
3838
}
3939

4040
mapping "aws_cognito_user_pool_domain" {
41-
domain = DomainType
41+
domain = any // DomainType is not appropriate for a fully-customized domain. See also https://github.com/terraform-linters/tflint-ruleset-aws/issues/156
4242
user_pool_id = UserPoolIdType
4343
certificate_arn = ArnType
4444
}
@@ -112,8 +112,3 @@ test "aws_cognito_user_pool_client" "name" {
112112
ok = "client"
113113
ng = "client/example"
114114
}
115-
116-
test "aws_cognito_user_pool_domain" "domain" {
117-
ok = "auth"
118-
ng = "auth example"
119-
}

rules/models/provider.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,6 @@ var Rules = []tflint.Rule{
170170
NewAwsCognitoUserPoolClientInvalidNameRule(),
171171
NewAwsCognitoUserPoolClientInvalidUserPoolIDRule(),
172172
NewAwsCognitoUserPoolDomainInvalidCertificateArnRule(),
173-
NewAwsCognitoUserPoolDomainInvalidDomainRule(),
174173
NewAwsCognitoUserPoolDomainInvalidUserPoolIDRule(),
175174
NewAwsCognitoUserPoolInvalidEmailVerificationMessageRule(),
176175
NewAwsCognitoUserPoolInvalidEmailVerificationSubjectRule(),

0 commit comments

Comments
 (0)