Skip to content

Commit 330ea4f

Browse files
committed
update docs
1 parent 60404ab commit 330ea4f

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

docs/rules/aws_security_group_egress_and_ingress_blocks_deprecated.md

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,18 @@ resource "aws_security_group" "foo" {
2626

2727
```
2828
$ tflint
29+
2 issue(s) found:
2930
30-
// TODO: Write the output when inspects the above code
31+
Notice: Replace this egress block with aws_vpc_security_group_egress_rule. Otherwise, rule conflicts, perpetual differences, and result in rules being overwritten may occur. (aws_security_group_egress_and_ingress_blocks_deprecated)
3132
33+
on test.tf line 4:
34+
4: egress {
35+
36+
Notice: Replace this ingress block with aws_vpc_security_group_ingress_rule. Otherwise, rule conflicts, perpetual differences, and result in rules being overwritten may occur. (aws_security_group_egress_and_ingress_blocks_deprecated)
37+
38+
on test.tf line 11:
39+
11: ingress {
40+
3241
```
3342

3443
## Why

rules/aws_security_group_egress_and_ingress_blocks_deprecated.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ func (r *AwsSecurityGroupEgressAndIngressBlocksDeprecatedRule) Check(runner tfli
5858
if block.Type == "egress" || block.Type == "ingress" {
5959
runner.EmitIssue(
6060
r,
61-
fmt.Sprintf("Replace this %s block with aws_vpc_security_group_ingress_rule. Otherwise, rule conflicts, perpetual differences, and result in rules being overwritten may occur.", block.Type),
61+
fmt.Sprintf("Replace this %s block with aws_vpc_security_group_%s_rule. Otherwise, rule conflicts, perpetual differences, and result in rules being overwritten may occur.", block.Type, block.Type),
6262
block.DefRange,
6363
)
6464
} else {

rules/aws_security_group_egress_and_ingress_blocks_deprecated_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ resource "aws_security_group" "test" {
5656
Expected: helper.Issues{
5757
{
5858
Rule: NewAwsSecurityGroupEgressAndIngressBlocksDeprecatedRule(),
59-
Message: "Replace this egress block with aws_vpc_security_group_ingress_rule. Otherwise, rule conflicts, perpetual differences, and result in rules being overwritten may occur.",
59+
Message: "Replace this egress block with aws_vpc_security_group_egress_rule. Otherwise, rule conflicts, perpetual differences, and result in rules being overwritten may occur.",
6060
Range: hcl.Range{
6161
Filename: "resource.tf",
6262
Start: hcl.Pos{Line: 5, Column: 3},

0 commit comments

Comments
 (0)