fix: implement remarks

Author: aristosvo

docs/rules/README.md

@@ -80,6 +80,15 @@ These rules enforce best practices and naming conventions:
 |[aws_security_group_rule_deprecated](aws_security_group_rule_deprecated.md)|Disallow using `aws_security_group_rule` resource||
 |[aws_provider_missing_default_tags](aws_provider_missing_default_tags.md)|Require specific tags for all AWS providers default tags||
 
+### Removing secrets from state
+
+These rules recommend best practices to keep sensitive information from state:
+
+|Rule|Description|Enabled by default|
+| --- | --- | --- |
+|[aws_ephemeral_resources](aws_ephemeral_resources.md)|Recommends using available ephemeral resources instead of the original data source. This is only valid for Terraform v1.10+.||
+|[aws_write_only_arguments](aws_write_only_arguments.md)|Recommends using available write-only arguments instead of the original sensitive attribute. This is only valid for Terraform v1.11+.||
+
 ### SDK-based Validations
 
 700+ rules based on the aws-sdk validations are also available:

rules/ephemeral/aws_ephemeral_resources.go

@@ -51,15 +51,12 @@ func (r *AwsEphemeralResourcesRule) Check(runner tflint.Runner) error {
 		}
 
 		for _, resource := range resources.Blocks {
-			if err := runner.EmitIssueWithFix(
+			if err := runner.EmitIssue(
 				r,
 				fmt.Sprintf("\"%s\" is a non-ephemeral data source, which means that all (sensitive) attributes are stored in state. Please use ephemeral resource \"%s\" instead.", resourceType, resourceType),
 				resource.TypeRange,
-				func(f tflint.Fixer) error {
-					return f.ReplaceText(resource.TypeRange, "ephemeral")
-				},
 			); err != nil {
-				return fmt.Errorf("failed to call EmitIssueWithFix(): %w", err)
+				return fmt.Errorf("failed to call EmitIssue(): %w", err)
 			}
 		}
 	}

rules/ephemeral/aws_ephemeral_resources_test.go

@@ -31,10 +31,6 @@ data "aws_eks_cluster_auth" "test" {
 					},
 				},
 			},
-			Fixed: `
-ephemeral "aws_eks_cluster_auth" "test" {
-}
-`,
 		},
 	}
 
@@ -48,11 +44,5 @@ ephemeral "aws_eks_cluster_auth" "test" {
 			t.Fatalf("Unexpected error occurred: %s", err)
 		}
 		helper.AssertIssues(t, tc.Expected, runner.Issues)
-
-		want := map[string]string{}
-		if tc.Fixed != "" {
-			want[filename] = tc.Fixed
-		}
-		helper.AssertChanges(t, want, runner.Changes())
 	}
 }