Fix \S pattern transform for backward compatibility

The Smithy models contain pattern "\S" for many string fields. This is
incorrect for fields that can be 1-128 characters. The pattern "\S"
literally means "exactly one non-whitespace character".

The Ruby SDK generator produced "^.*\S.*$" (contains at least one
non-whitespace character) for these same fields, which is the correct
semantic validation.

This commit fixes the pattern transform to maintain backward
compatibility with the Ruby SDK behavior, affecting 59 rules across
WAF, WAFRegional, WAFv2, SecurityHub, Config, and other services.

Author: bendrucker

rules/models/aws_config_config_rule_invalid_name.go

@@ -29,7 +29,7 @@ func NewAwsConfigConfigRuleInvalidNameRule() *AwsConfigConfigRuleInvalidNameRule
 		attributeName: "name",
 		max:           128,
 		min:           1,
-		pattern:       regexp.MustCompile(`^\S$`),
+		pattern:       regexp.MustCompile(`^.*\S.*$`),
 	}
 }
 
@@ -90,7 +90,7 @@ func (r *AwsConfigConfigRuleInvalidNameRule) Check(runner tflint.Runner) error {
 			if !r.pattern.MatchString(val) {
 				runner.EmitIssue(
 					r,
-					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^\S$`),
+					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^.*\S.*$`),
 					attribute.Expr.Range(),
 				)
 			}

rules/models/aws_config_remediation_configuration_invalid_config_rule_name.go

@@ -29,7 +29,7 @@ func NewAwsConfigRemediationConfigurationInvalidConfigRuleNameRule() *AwsConfigR
 		attributeName: "config_rule_name",
 		max:           128,
 		min:           1,
-		pattern:       regexp.MustCompile(`^\S$`),
+		pattern:       regexp.MustCompile(`^.*\S.*$`),
 	}
 }
 
@@ -90,7 +90,7 @@ func (r *AwsConfigRemediationConfigurationInvalidConfigRuleNameRule) Check(runne
 			if !r.pattern.MatchString(val) {
 				runner.EmitIssue(
 					r,
-					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^\S$`),
+					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^.*\S.*$`),
 					attribute.Expr.Range(),
 				)
 			}

rules/models/aws_elasticache_user_invalid_access_string.go

@@ -25,7 +25,7 @@ func NewAwsElastiCacheUserInvalidAccessStringRule() *AwsElastiCacheUserInvalidAc
 	return &AwsElastiCacheUserInvalidAccessStringRule{
 		resourceType:  "aws_elasticache_user",
 		attributeName: "access_string",
-		pattern:       regexp.MustCompile(`^\S$`),
+		pattern:       regexp.MustCompile(`^.*\S.*$`),
 	}
 }
 
@@ -72,7 +72,7 @@ func (r *AwsElastiCacheUserInvalidAccessStringRule) Check(runner tflint.Runner)
 			if !r.pattern.MatchString(val) {
 				runner.EmitIssue(
 					r,
-					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^\S$`),
+					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^.*\S.*$`),
 					attribute.Expr.Range(),
 				)
 			}

rules/models/aws_gamelift_alias_invalid_name.go

@@ -29,7 +29,7 @@ func NewAwsGameliftAliasInvalidNameRule() *AwsGameliftAliasInvalidNameRule {
 		attributeName: "name",
 		max:           1024,
 		min:           1,
-		pattern:       regexp.MustCompile(`^\S$`),
+		pattern:       regexp.MustCompile(`^.*\S.*$`),
 	}
 }
 
@@ -90,7 +90,7 @@ func (r *AwsGameliftAliasInvalidNameRule) Check(runner tflint.Runner) error {
 			if !r.pattern.MatchString(val) {
 				runner.EmitIssue(
 					r,
-					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^\S$`),
+					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^.*\S.*$`),
 					attribute.Expr.Range(),
 				)
 			}

rules/models/aws_glue_schema_invalid_schema_definition.go

@@ -29,7 +29,7 @@ func NewAwsGlueSchemaInvalidSchemaDefinitionRule() *AwsGlueSchemaInvalidSchemaDe
 		attributeName: "schema_definition",
 		max:           170000,
 		min:           1,
-		pattern:       regexp.MustCompile(`^\S$`),
+		pattern:       regexp.MustCompile(`^.*\S.*$`),
 	}
 }
 
@@ -90,7 +90,7 @@ func (r *AwsGlueSchemaInvalidSchemaDefinitionRule) Check(runner tflint.Runner) e
 			if !r.pattern.MatchString(val) {
 				runner.EmitIssue(
 					r,
-					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^\S$`),
+					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^.*\S.*$`),
 					attribute.Expr.Range(),
 				)
 			}

rules/models/aws_lightsail_instance_invalid_blueprint_id.go

@@ -25,7 +25,7 @@ func NewAwsLightsailInstanceInvalidBlueprintIDRule() *AwsLightsailInstanceInvali
 	return &AwsLightsailInstanceInvalidBlueprintIDRule{
 		resourceType:  "aws_lightsail_instance",
 		attributeName: "blueprint_id",
-		pattern:       regexp.MustCompile(`^\S$`),
+		pattern:       regexp.MustCompile(`^.*\S.*$`),
 	}
 }
 
@@ -72,7 +72,7 @@ func (r *AwsLightsailInstanceInvalidBlueprintIDRule) Check(runner tflint.Runner)
 			if !r.pattern.MatchString(val) {
 				runner.EmitIssue(
 					r,
-					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^\S$`),
+					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^.*\S.*$`),
 					attribute.Expr.Range(),
 				)
 			}

rules/models/aws_lightsail_instance_invalid_bundle_id.go

@@ -25,7 +25,7 @@ func NewAwsLightsailInstanceInvalidBundleIDRule() *AwsLightsailInstanceInvalidBu
 	return &AwsLightsailInstanceInvalidBundleIDRule{
 		resourceType:  "aws_lightsail_instance",
 		attributeName: "bundle_id",
-		pattern:       regexp.MustCompile(`^\S$`),
+		pattern:       regexp.MustCompile(`^.*\S.*$`),
 	}
 }
 
@@ -72,7 +72,7 @@ func (r *AwsLightsailInstanceInvalidBundleIDRule) Check(runner tflint.Runner) er
 			if !r.pattern.MatchString(val) {
 				runner.EmitIssue(
 					r,
-					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^\S$`),
+					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^.*\S.*$`),
 					attribute.Expr.Range(),
 				)
 			}

rules/models/aws_memorydb_user_invalid_access_string.go

@@ -25,7 +25,7 @@ func NewAwsMemoryDBUserInvalidAccessStringRule() *AwsMemoryDBUserInvalidAccessSt
 	return &AwsMemoryDBUserInvalidAccessStringRule{
 		resourceType:  "aws_memorydb_user",
 		attributeName: "access_string",
-		pattern:       regexp.MustCompile(`^\S$`),
+		pattern:       regexp.MustCompile(`^.*\S.*$`),
 	}
 }
 
@@ -72,7 +72,7 @@ func (r *AwsMemoryDBUserInvalidAccessStringRule) Check(runner tflint.Runner) err
 			if !r.pattern.MatchString(val) {
 				runner.EmitIssue(
 					r,
-					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^\S$`),
+					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^.*\S.*$`),
 					attribute.Expr.Range(),
 				)
 			}

rules/models/aws_networkfirewall_resource_policy_invalid_policy.go

@@ -29,7 +29,7 @@ func NewAwsNetworkfirewallResourcePolicyInvalidPolicyRule() *AwsNetworkfirewallR
 		attributeName: "policy",
 		max:           395000,
 		min:           1,
-		pattern:       regexp.MustCompile(`^\S$`),
+		pattern:       regexp.MustCompile(`^.*\S.*$`),
 	}
 }
 
@@ -90,7 +90,7 @@ func (r *AwsNetworkfirewallResourcePolicyInvalidPolicyRule) Check(runner tflint.
 			if !r.pattern.MatchString(val) {
 				runner.EmitIssue(
 					r,
-					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^\S$`),
+					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^.*\S.*$`),
 					attribute.Expr.Range(),
 				)
 			}

rules/models/aws_securityhub_action_target_invalid_description.go

@@ -25,7 +25,7 @@ func NewAwsSecurityhubActionTargetInvalidDescriptionRule() *AwsSecurityhubAction
 	return &AwsSecurityhubActionTargetInvalidDescriptionRule{
 		resourceType:  "aws_securityhub_action_target",
 		attributeName: "description",
-		pattern:       regexp.MustCompile(`^\S$`),
+		pattern:       regexp.MustCompile(`^.*\S.*$`),
 	}
 }
 
@@ -72,7 +72,7 @@ func (r *AwsSecurityhubActionTargetInvalidDescriptionRule) Check(runner tflint.R
 			if !r.pattern.MatchString(val) {
 				runner.EmitIssue(
 					r,
-					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^\S$`),
+					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^.*\S.*$`),
 					attribute.Expr.Range(),
 				)
 			}