autogenerated maintenance (#358)

Co-authored-by: PatMyron <[email protected]>

Author: github-actions[bot]

aws/mock/rds.go

@@ -335,7 +335,6 @@ These rules enforce best practices and naming conventions:
 |aws_cloudwatch_metric_alarm_invalid_alarm_name|✔|
 |aws_cloudwatch_metric_alarm_invalid_comparison_operator|✔|
 |aws_cloudwatch_metric_alarm_invalid_evaluate_low_sample_count_percentiles|✔|
-|aws_cloudwatch_metric_alarm_invalid_extended_statistic|✔|
 |aws_cloudwatch_metric_alarm_invalid_metric_name|✔|
 |aws_cloudwatch_metric_alarm_invalid_namespace|✔|
 |aws_cloudwatch_metric_alarm_invalid_statistic|✔|

docs/rules/README.md

@@ -4,7 +4,7 @@ go 1.19
 
 require (
 	github.com/agext/levenshtein v1.2.2 // indirect
-	github.com/aws/aws-sdk-go v1.44.54
+	github.com/aws/aws-sdk-go v1.44.76
 	github.com/dave/dst v0.27.0
 	github.com/fatih/color v1.9.0 // indirect
 	github.com/golang/mock v1.6.0

go.mod

@@ -7,8 +7,8 @@ github.com/antihax/optional v1.0.0/go.mod h1:uupD/76wgC+ih3iEmQUL+0Ugr19nfwCT1kd
 github.com/apparentlymart/go-textseg/v13 v13.0.0 h1:Y+KvPE1NYz0xl601PVImeQfFyEy6iT90AvPUL1NNfNw=
 github.com/apparentlymart/go-textseg/v13 v13.0.0/go.mod h1:ZK2fH7c4NqDTLtiYLvIkEghdlcqw7yxLeM89kiTRPUo=
 github.com/aws/aws-sdk-go v1.31.9/go.mod h1:5zCpMtNQVjRREroY7sYe8lOMRSxkhG6MZveU8YkpAk0=
-github.com/aws/aws-sdk-go v1.44.54 h1:zfFptZ0iLuk+psnRLk+o0NMgd/pBsALlNE7i40iOmFA=
-github.com/aws/aws-sdk-go v1.44.54/go.mod h1:y4AeaBuwd2Lk+GepC1E9v0qOiTws0MIWAX4oIKwKHZo=
+github.com/aws/aws-sdk-go v1.44.76 h1:5e8yGO/XeNYKckOjpBKUd5wStf0So3CrQIiOMCVLpOI=
+github.com/aws/aws-sdk-go v1.44.76/go.mod h1:y4AeaBuwd2Lk+GepC1E9v0qOiTws0MIWAX4oIKwKHZo=
 github.com/census-instrumentation/opencensus-proto v0.2.1/go.mod h1:f6KPmirojxKA12rnyqOA5BBL4O983OfeGPqjHWSTneU=
 github.com/cespare/xxhash/v2 v2.1.1/go.mod h1:VGX0DQ3Q6kWi7AoAeZDth3/j3BFtOZR5XLFGgcrjCOs=
 github.com/client9/misspell v0.3.4/go.mod h1:qj6jICC3Q7zFZvVWo7KLAzC3yx5G7kyvSDkc90ppPyw=

go.sum

@@ -29,7 +29,7 @@ func NewAwsAccountAlternateContactInvalidEmailAddressRule() *AwsAccountAlternate
 		attributeName: "email_address",
 		max:           64,
 		min:           1,
-		pattern:       regexp.MustCompile(`^[\w+=,.-]+@[\w.-]+\.[\w]+$`),
+		pattern:       regexp.MustCompile(`^[\s]*[\w+=.#!&-]+@[\w.-]+\.[\w]+[\s]*$`),
 	}
 }
 
@@ -93,7 +93,7 @@ func (r *AwsAccountAlternateContactInvalidEmailAddressRule) Check(runner tflint.
 			if !r.pattern.MatchString(val) {
 				runner.EmitIssue(
 					r,
-					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^[\w+=,.-]+@[\w.-]+\.[\w]+$`),
+					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^[\s]*[\w+=.#!&-]+@[\w.-]+\.[\w]+[\s]*$`),
 					attribute.Expr.Range(),
 				)
 			}

rules/models/aws-sdk-go

@@ -3,6 +3,9 @@
 package models
 
 import (
+	"fmt"
+	"regexp"
+
 	"github.com/terraform-linters/tflint-plugin-sdk/hclext"
 	"github.com/terraform-linters/tflint-plugin-sdk/logger"
 	"github.com/terraform-linters/tflint-plugin-sdk/tflint"
@@ -16,15 +19,17 @@ type AwsCodeartifactDomainPermissionsPolicyInvalidPolicyDocumentRule struct {
 	attributeName string
 	max           int
 	min           int
+	pattern       *regexp.Regexp
 }
 
 // NewAwsCodeartifactDomainPermissionsPolicyInvalidPolicyDocumentRule returns new rule with default attributes
 func NewAwsCodeartifactDomainPermissionsPolicyInvalidPolicyDocumentRule() *AwsCodeartifactDomainPermissionsPolicyInvalidPolicyDocumentRule {
 	return &AwsCodeartifactDomainPermissionsPolicyInvalidPolicyDocumentRule{
 		resourceType:  "aws_codeartifact_domain_permissions_policy",
 		attributeName: "policy_document",
-		max:           5120,
+		max:           7168,
 		min:           1,
+		pattern:       regexp.MustCompile(`^[\P{C}\s]+$`),
 	}
 }
 
@@ -74,7 +79,7 @@ func (r *AwsCodeartifactDomainPermissionsPolicyInvalidPolicyDocumentRule) Check(
 			if len(val) > r.max {
 				runner.EmitIssue(
 					r,
-					"policy_document must be 5120 characters or less",
+					"policy_document must be 7168 characters or less",
 					attribute.Expr.Range(),
 				)
 			}
@@ -85,6 +90,13 @@ func (r *AwsCodeartifactDomainPermissionsPolicyInvalidPolicyDocumentRule) Check(
 					attribute.Expr.Range(),
 				)
 			}
+			if !r.pattern.MatchString(val) {
+				runner.EmitIssue(
+					r,
+					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^[\P{C}\s]+$`),
+					attribute.Expr.Range(),
+				)
+			}
 			return nil
 		})
 		if err != nil {

rules/models/aws_account_alternate_contact_invalid_email_address.go

@@ -27,7 +27,7 @@ func NewAwsCodeartifactRepositoryInvalidDescriptionRule() *AwsCodeartifactReposi
 		resourceType:  "aws_codeartifact_repository",
 		attributeName: "description",
 		max:           1000,
-		pattern:       regexp.MustCompile(`^\P{C}+$`),
+		pattern:       regexp.MustCompile(`^\P{C}*$`),
 	}
 }
 
@@ -84,7 +84,7 @@ func (r *AwsCodeartifactRepositoryInvalidDescriptionRule) Check(runner tflint.Ru
 			if !r.pattern.MatchString(val) {
 				runner.EmitIssue(
 					r,
-					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^\P{C}+$`),
+					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^\P{C}*$`),
 					attribute.Expr.Range(),
 				)
 			}

rules/models/aws_codeartifact_domain_permissions_policy_invalid_policy_document.go

@@ -3,6 +3,9 @@
 package models
 
 import (
+	"fmt"
+	"regexp"
+
 	"github.com/terraform-linters/tflint-plugin-sdk/hclext"
 	"github.com/terraform-linters/tflint-plugin-sdk/logger"
 	"github.com/terraform-linters/tflint-plugin-sdk/tflint"
@@ -16,15 +19,17 @@ type AwsCodeartifactRepositoryPermissionsPolicyInvalidPolicyDocumentRule struct
 	attributeName string
 	max           int
 	min           int
+	pattern       *regexp.Regexp
 }
 
 // NewAwsCodeartifactRepositoryPermissionsPolicyInvalidPolicyDocumentRule returns new rule with default attributes
 func NewAwsCodeartifactRepositoryPermissionsPolicyInvalidPolicyDocumentRule() *AwsCodeartifactRepositoryPermissionsPolicyInvalidPolicyDocumentRule {
 	return &AwsCodeartifactRepositoryPermissionsPolicyInvalidPolicyDocumentRule{
 		resourceType:  "aws_codeartifact_repository_permissions_policy",
 		attributeName: "policy_document",
-		max:           5120,
+		max:           7168,
 		min:           1,
+		pattern:       regexp.MustCompile(`^[\P{C}\s]+$`),
 	}
 }
 
@@ -74,7 +79,7 @@ func (r *AwsCodeartifactRepositoryPermissionsPolicyInvalidPolicyDocumentRule) Ch
 			if len(val) > r.max {
 				runner.EmitIssue(
 					r,
-					"policy_document must be 5120 characters or less",
+					"policy_document must be 7168 characters or less",
 					attribute.Expr.Range(),
 				)
 			}
@@ -85,6 +90,13 @@ func (r *AwsCodeartifactRepositoryPermissionsPolicyInvalidPolicyDocumentRule) Ch
 					attribute.Expr.Range(),
 				)
 			}
+			if !r.pattern.MatchString(val) {
+				runner.EmitIssue(
+					r,
+					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^[\P{C}\s]+$`),
+					attribute.Expr.Range(),
+				)
+			}
 			return nil
 		})
 		if err != nil {

rules/models/aws_codeartifact_repository_invalid_description.go

@@ -26,6 +26,7 @@ func NewAwsGlobalacceleratorAcceleratorInvalidIPAddressTypeRule() *AwsGlobalacce
 		attributeName: "ip_address_type",
 		enum: []string{
 			"IPV4",
+			"DUAL_STACK",
 		},
 	}
 }