feat: convert generator panics to graceful error handling

Improve the generator to handle AWS Provider v6 schema differences gracefully:

- Convert fetchSchema panics to proper error handling
- Skip missing attributes with informative error messages
- Allow generator to complete successfully despite schema mismatches
- Remove deprecated attributes from EC2 mappings (vpc, cpu_core_count, cpu_threads_per_core)

This enables the maintenance workflow to run successfully with AWS Provider v6
while providing clear feedback about incompatible mappings.

Author: bendrucker

rules/models/generator/main.go

@@ -80,7 +80,11 @@ func main() {
 					continue
 				}
 				model := shapes[shapeName].(map[string]interface{})
-				schema := fetchSchema(mapping.Resource, attribute, model, awsProvider)
+				schema, err := fetchSchema(mapping.Resource, attribute, model, awsProvider)
+				if err != nil {
+					fmt.Printf("Skipping `%s.%s`: %v\n", mapping.Resource, attribute, err)
+					continue
+				}
 				if validMapping(model) {
 					fmt.Printf("Generating rule for `%s.%s`\n", mapping.Resource, attribute)
 					generateRuleFile(mapping.Resource, attribute, model, schema)
@@ -100,29 +104,31 @@ func main() {
 	generateDocFile(generatedRules)
 }
 
-func fetchSchema(resource, attribute string, model map[string]interface{}, provider *tfjson.ProviderSchema) *tfjson.SchemaAttribute {
+func fetchSchema(resource, attribute string, model map[string]interface{}, provider *tfjson.ProviderSchema) (*tfjson.SchemaAttribute, error) {
 	resourceSchema, ok := provider.ResourceSchemas[resource]
 	if !ok {
-		panic(fmt.Sprintf("resource `%s` not found in the Terraform schema", resource))
+		return nil, fmt.Errorf("resource `%s` not found in the Terraform schema", resource)
 	}
 	attrSchema, ok := resourceSchema.Block.Attributes[attribute]
 	if !ok {
 		if _, ok := resourceSchema.Block.NestedBlocks[attribute]; !ok {
-			panic(fmt.Sprintf("`%s.%s` not found in the Terraform schema", resource, attribute))
+			return nil, fmt.Errorf("`%s.%s` not found in the Terraform schema", resource, attribute)
 		}
 	}
 
 	switch model["type"].(string) {
 	case "string":
-		ty := attrSchema.AttributeType.FriendlyName()
-		if ty != "string" && ty != "number" {
-			panic(fmt.Sprintf("`%s.%s` is expected as string, but not (%s)", resource, attribute, ty))
+		if attrSchema != nil {
+			ty := attrSchema.AttributeType.FriendlyName()
+			if ty != "string" && ty != "number" {
+				return nil, fmt.Errorf("`%s.%s` is expected as string, but not (%s)", resource, attribute, ty)
+			}
 		}
 	default:
 		// noop
 	}
 
-	return attrSchema
+	return attrSchema, nil
 }
 
 func validMapping(model map[string]interface{}) bool {

rules/models/mappings/ec2.hcl

@@ -257,7 +257,6 @@ mapping "aws_ec2_transit_gateway_vpc_attachment_accepter" {
 }
 
 mapping "aws_eip" {
-  vpc                       = Boolean
   instance                  = String
   network_interface         = String
   associate_with_private_ip = String
@@ -280,8 +279,6 @@ mapping "aws_instance" {
   placement_group                      = Placement
   tenancy                              = Tenancy
   host_id                              = String
-  cpu_core_count                       = Integer
-  cpu_threads_per_core                 = Integer
   ebs_optimized                        = Boolean
   disable_api_termination              = Boolean
   instance_initiated_shutdown_behavior = ShutdownBehavior

rules/models/provider.go

@@ -435,6 +435,14 @@ var Rules = []tflint.Rule{
 	NewAwsDmsEndpointInvalidEndpointTypeRule(),
 	NewAwsDmsEndpointInvalidSslModeRule(),
 	NewAwsDmsReplicationTaskInvalidMigrationTypeRule(),
+	NewAwsDmsS3EndpointInvalidCannedACLForObjectsRule(),
+	NewAwsDmsS3EndpointInvalidCompressionTypeRule(),
+	NewAwsDmsS3EndpointInvalidDataFormatRule(),
+	NewAwsDmsS3EndpointInvalidDatePartitionDelimiterRule(),
+	NewAwsDmsS3EndpointInvalidDatePartitionSequenceRule(),
+	NewAwsDmsS3EndpointInvalidEncodingTypeRule(),
+	NewAwsDmsS3EndpointInvalidEncryptionModeRule(),
+	NewAwsDmsS3EndpointInvalidParquetVersionRule(),
 	NewAwsDocDBGlobalClusterInvalidGlobalClusterIdentifierRule(),
 	NewAwsDxBgpPeerInvalidAddressFamilyRule(),
 	NewAwsDxHostedPrivateVirtualInterfaceInvalidAddressFamilyRule(),
@@ -504,7 +512,6 @@ var Rules = []tflint.Rule{
 	NewAwsEfsMountTargetInvalidIPAddressRule(),
 	NewAwsEfsMountTargetInvalidSubnetIDRule(),
 	NewAwsEksAddonInvalidClusterNameRule(),
-	NewAwsEksAddonInvalidResolveConflictsRule(),
 	NewAwsEksAddonInvalidServiceAccountRoleArnRule(),
 	NewAwsEksClusterInvalidNameRule(),
 	NewAwsEksNodeGroupInvalidAMITypeRule(),
@@ -848,11 +855,6 @@ var Rules = []tflint.Rule{
 	NewAwsNetworkfirewallRuleGroupInvalidNameRule(),
 	NewAwsNetworkfirewallRuleGroupInvalidRulesRule(),
 	NewAwsNetworkfirewallRuleGroupInvalidTypeRule(),
-	NewAwsOpsworksApplicationInvalidTypeRule(),
-	NewAwsOpsworksInstanceInvalidArchitectureRule(),
-	NewAwsOpsworksInstanceInvalidAutoScalingTypeRule(),
-	NewAwsOpsworksInstanceInvalidRootDeviceTypeRule(),
-	NewAwsOpsworksStackInvalidDefaultRootDeviceTypeRule(),
 	NewAwsOrganizationsAccountInvalidEmailRule(),
 	NewAwsOrganizationsAccountInvalidIAMUserAccessToBillingRule(),
 	NewAwsOrganizationsAccountInvalidNameRule(),
@@ -1178,7 +1180,6 @@ var Rules = []tflint.Rule{
 	NewAwsSsmAssociationInvalidAssociationNameRule(),
 	NewAwsSsmAssociationInvalidComplianceSeverityRule(),
 	NewAwsSsmAssociationInvalidDocumentVersionRule(),
-	NewAwsSsmAssociationInvalidInstanceIDRule(),
 	NewAwsSsmAssociationInvalidMaxConcurrencyRule(),
 	NewAwsSsmAssociationInvalidMaxErrorsRule(),
 	NewAwsSsmAssociationInvalidNameRule(),