Skip to content

Commit b58242c

Browse files
authored
Fix aws_acm_certificate.private_key mapping and remove the rule (#576)
1 parent 2751dc5 commit b58242c

File tree

3 files changed

+2
-4
lines changed

3 files changed

+2
-4
lines changed

docs/rules/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ These rules enforce best practices and naming conventions:
9292
|aws_acm_certificate_invalid_certificate_authority_arn||
9393
|aws_acm_certificate_invalid_certificate_body||
9494
|aws_acm_certificate_invalid_certificate_chain||
95-
|aws_acm_certificate_invalid_private_key||
9695
|aws_acm_certificate_validation_invalid_certificate_arn||
9796
|aws_acmpca_certificate_authority_certificate_invalid_certificate_authority_arn||
9897
|aws_acmpca_certificate_authority_invalid_type||

rules/models/mappings/acm.hcl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ mapping "aws_acm_certificate" {
44
// domain_name = DomainNameString
55
subject_alternative_names = DomainList
66
// validation_method = ValidationMethod
7-
private_key = PrivateKey
7+
private_key = PrivateKeyBlob
88
certificate_body = CertificateBody
99
certificate_chain = CertificateChain
1010
certificate_authority_arn = PcaArn
@@ -18,4 +18,4 @@ mapping "aws_acm_certificate_validation" {
1818
test "aws_acm_certificate" "certificate_authority_arn" {
1919
ok = "arn:aws:acm-pca:us-east-1:0000000000:certificate-authority/xxxxxx-xxx-xxx-xxxx-xxxxxxxxx"
2020
ng = "arn:aws:unknown-service:us-east-1:0000000000:certificate-authority/xxxxxx-xxx-xxx-xxxx-xxxxxxxxx"
21-
}
21+
}

rules/models/provider.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ var Rules = []tflint.Rule{
1717
NewAwsAcmCertificateInvalidCertificateAuthorityArnRule(),
1818
NewAwsAcmCertificateInvalidCertificateBodyRule(),
1919
NewAwsAcmCertificateInvalidCertificateChainRule(),
20-
NewAwsAcmCertificateInvalidPrivateKeyRule(),
2120
NewAwsAcmCertificateValidationInvalidCertificateArnRule(),
2221
NewAwsAcmpcaCertificateAuthorityCertificateInvalidCertificateAuthorityArnRule(),
2322
NewAwsAcmpcaCertificateAuthorityInvalidTypeRule(),

0 commit comments

Comments
 (0)