Fix incorrect mapping about aws_servicecatalog_portfolio_share type (#721)

wata727 · web-flow · commit f15e83ca8c03 · 2024-10-14T22:19:20.000+09:00
diff --git a/rules/models/aws_servicecatalog_portfolio_share_invalid_type.go b/rules/models/aws_servicecatalog_portfolio_share_invalid_type.go
@@ -25,9 +25,10 @@ func NewAwsServicecatalogPortfolioShareInvalidTypeRule() *AwsServicecatalogPortf
 		resourceType:  "aws_servicecatalog_portfolio_share",
 		attributeName: "type",
 		enum: []string{
-			"IMPORTED",
-			"AWS_SERVICECATALOG",
-			"AWS_ORGANIZATIONS",
+			"ACCOUNT",
+			"ORGANIZATION",
+			"ORGANIZATIONAL_UNIT",
+			"ORGANIZATION_MEMBER_ACCOUNT",
 		},
 	}
 }
diff --git a/rules/models/mappings/servicecatalog.hcl b/rules/models/mappings/servicecatalog.hcl
@@ -24,7 +24,7 @@ mapping "aws_servicecatalog_portfolio" {
 mapping "aws_servicecatalog_portfolio_share" {
   portfolio_id = Id
   principal_id = Id
-  type = PortfolioShareType
+  type = DescribePortfolioShareType
   accept_language = AcceptLanguage
 }
 

Original file line number	Diff line number	Diff line change
`@@ -25,9 +25,10 @@ func NewAwsServicecatalogPortfolioShareInvalidTypeRule() *AwsServicecatalogPortf`
`25`	`25`	`resourceType: "aws_servicecatalog_portfolio_share",`
`26`	`26`	`attributeName: "type",`
`27`	`27`	`enum: []string{`
`28`		`- "IMPORTED",`
`29`		`- "AWS_SERVICECATALOG",`
`30`		`- "AWS_ORGANIZATIONS",`
	`28`	`+ "ACCOUNT",`
	`29`	`+ "ORGANIZATION",`
	`30`	`+ "ORGANIZATIONAL_UNIT",`
	`31`	`+ "ORGANIZATION_MEMBER_ACCOUNT",`
`31`	`32`	`},`
`32`	`33`	`}`
`33`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ mapping "aws_servicecatalog_portfolio" {`
`24`	`24`	`mapping "aws_servicecatalog_portfolio_share" {`
`25`	`25`	`portfolio_id = Id`
`26`	`26`	`principal_id = Id`
`27`		`- type = PortfolioShareType`
	`27`	`+ type = DescribePortfolioShareType`
`28`	`28`	`accept_language = AcceptLanguage`
`29`	`29`	`}`
`30`	`30`