Skip to content

Commit f43c87f

Browse files
committed
fix review issues
1 parent 6e133d2 commit f43c87f

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

docs/rules/aws_security_group_rule_deprecated.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
# aws_security_group_rule_deprecated
22

3-
// TODO: Write the rule's description here
3+
The `aws_security_group_rule` resource should be replaced with `aws_vpc_security_group_egress_rule` or `aws_vpc_security_group_ingress_rule`. It lacks support of unique IDs, tags, and descriptions, and has difficulties managing multiple CIDR blocks.
44

55
## Example
66

77
```hcl
88
resource "aws_security_group_rule" "foo" {
99
security_group_id = "sg-12345678"
10+
type = "ingress"
1011
}
1112
```
1213

@@ -22,9 +23,7 @@ Warning: Consider using aws_vpc_security_group_egress_rule or aws_vpc_security_g
2223
2324
## Why
2425
25-
Avoid using the `aws_security_group_rule` resource, as it struggles with managing multiple CIDR blocks, and, due to the historical lack of unique IDs, tags and descriptions.
26-
27-
For further information, see the [Terraform documentation](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/security_group_rule).
26+
Avoid using the [`aws_security_group_rule`](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/security_group_rule) resource because it has difficulties managing multiple CIDR blocks and historically lacks unique IDs, tags, and descriptions. To prevent these issues, follow the current best practice of using the `aws_vpc_security_group_egress_rule` and `aws_vpc_security_group_ingress_rule` resources.
2827
2928
## How To Fix
3029

0 commit comments

Comments
 (0)