Remove unnecessary WorkSpaces pattern transform

The Smithy pattern for WorkSpaces directory IDs has a redundant
trailing $ anchor: `^(d-...$)|(wsd-...$)$`

While the final $ is redundant (both branches already have $), it
doesn't change behavior - the patterns are functionally identical.
Master was missing this final $, but there's no benefit to removing
it, so keep the Smithy pattern as-is to minimize diffs.

Author: bendrucker

rules/models/aws_workspaces_directory_invalid_directory_id.go

@@ -29,7 +29,7 @@ func NewAwsWorkspacesDirectoryInvalidDirectoryIDRule() *AwsWorkspacesDirectoryIn
 		attributeName: "directory_id",
 		max:           65,
 		min:           10,
-		pattern:       regexp.MustCompile(`(d-[0-9a-f]{8,63}$)|(wsd-[0-9a-z]{8,63}$)`),
+		pattern:       regexp.MustCompile(`^(d-[0-9a-f]{8,63}$)|(wsd-[0-9a-z]{8,63}$)$`),
 	}
 }
 
@@ -90,7 +90,7 @@ func (r *AwsWorkspacesDirectoryInvalidDirectoryIDRule) Check(runner tflint.Runne
 			if !r.pattern.MatchString(val) {
 				runner.EmitIssue(
 					r,
-					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `(d-[0-9a-f]{8,63}$)|(wsd-[0-9a-z]{8,63}$)`),
+					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^(d-[0-9a-f]{8,63}$)|(wsd-[0-9a-z]{8,63}$)$`),
 					attribute.Expr.Range(),
 				)
 			}

rules/models/aws_workspaces_workspace_invalid_directory_id.go

@@ -29,7 +29,7 @@ func NewAwsWorkspacesWorkspaceInvalidDirectoryIDRule() *AwsWorkspacesWorkspaceIn
 		attributeName: "directory_id",
 		max:           65,
 		min:           10,
-		pattern:       regexp.MustCompile(`(d-[0-9a-f]{8,63}$)|(wsd-[0-9a-z]{8,63}$)`),
+		pattern:       regexp.MustCompile(`^(d-[0-9a-f]{8,63}$)|(wsd-[0-9a-z]{8,63}$)$`),
 	}
 }
 
@@ -90,7 +90,7 @@ func (r *AwsWorkspacesWorkspaceInvalidDirectoryIDRule) Check(runner tflint.Runne
 			if !r.pattern.MatchString(val) {
 				runner.EmitIssue(
 					r,
-					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `(d-[0-9a-f]{8,63}$)|(wsd-[0-9a-z]{8,63}$)`),
+					fmt.Sprintf(`"%s" does not match valid pattern %s`, truncateLongMessage(val), `^(d-[0-9a-f]{8,63}$)|(wsd-[0-9a-z]{8,63}$)$`),
 					attribute.Expr.Range(),
 				)
 			}

rules/models/generator/rule.go

@@ -217,15 +217,7 @@ func applyCompatibilityTransforms(pattern string) string {
 		"^\\{####\\}$": "^.*\\{####\\}.*$",
 	}
 
-	// WorkSpaces directory IDs: Smithy pattern has redundant end anchors ($)
-	// inside each alternation branch AND at the end of the pattern.
-	// Pattern "(foo$)|(bar$)$" is equivalent to "(foo)|(bar)" when the outer
-	// anchors are present. Remove inner anchors for cleaner regex.
-	workspacesDirectoryPatterns := map[string]string{
-		"^(d-[0-9a-f]{8,63}$)|(wsd-[0-9a-z]{8,63}$)$": "(d-[0-9a-f]{8,63}$)|(wsd-[0-9a-z]{8,63}$)",
-	}
-
-	for _, transforms := range []map[string]string{arnRolePatterns, cognitoMessagePatterns, workspacesDirectoryPatterns} {
+	for _, transforms := range []map[string]string{arnRolePatterns, cognitoMessagePatterns} {
 		if transformed, exists := transforms[pattern]; exists {
 			return transformed
 		}