[FEATURE] Set of new rules : tflint rules based in some terraform-best-pratices naming convention guidelines

[evairmarinho]

Introduction

terraform-best-pratices is an open-source project that lists several best practices for Terraform code. As tflint is a tool to help ensure good practices as well, it would be interesting for the project to be aligned with initiatives such as terraform-best-pratices .

Proposal

Ensuring the following premises regarding the part of naming convention:

Resource and data source arguments

• Do not repeat resource type in resource name (not partially, nor completely):
• Include argument count / for_each inside resource or data source block as the first argument at the top and separate by newline after it.
• Include argument tags, if supported by resource, as the last real argument, following by depends_on and lifecycle, if necessary. All of these should be separated by a single empty line.

Variables

• Order keys in a variable block like this: description , type, default, validation.

References

https://www.terraform-best-practices.com/
https://www.terraform-best-practices.com/naming