Merge pull request #19 from terraform-module/chore/refresh

keep up-to-date. update .github actions

Author: ivankatliarchuk

.github/workflows/lint.yml

@@ -0,0 +1,42 @@
+name: linter
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+
+env:
+  # renovate: datasource=github-releases depName=terraform-linters/tflint
+  TFLINT_VERSION: v0.34.0
+
+jobs:
+  tflint:
+    runs-on: ${{ matrix.os }}
+
+    strategy:
+      matrix:
+        os: [ubuntu-latest]
+
+    steps:
+    - uses: actions/checkout@v2
+      name: Checkout source code
+
+    - uses: actions/cache@v2
+      name: Cache plugin dir
+      with:
+        path: ~/.tflint.d/plugins
+        key: ${{ matrix.os }}-tflint-${{ hashFiles('.tflint.hcl') }}
+
+    - uses: terraform-linters/setup-tflint@v1
+      name: Setup TFLint
+      with:
+        tflint_version: ${{ env.RENOVATE_CONFIG_FOLDER }}
+
+    - name: Show version
+      run: tflint --version
+
+    - name: Init TFLint
+      run: tflint --init
+
+    - name: Run TFLint
+      run: tflint -f compact

.github/workflows/main.yaml

@@ -0,0 +1,49 @@
+name: 'validate-pr-title'
+
+on:
+  pull_request_target:
+    types:
+      - opened
+      - edited
+      - synchronize
+
+jobs:
+  main:
+    name: validate pr title
+    runs-on: ubuntu-latest
+    steps:
+      # Please look up the latest version from
+      # https://github.com/amannn/action-semantic-pull-request/releases
+      - uses: amannn/[email protected]
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          # Configure which types are allowed.
+          # Default: https://github.com/commitizen/conventional-commit-types
+          types: |
+            fix
+            feat
+            docs
+            ci
+            chore
+          # Configure that a scope must always be provided.
+          requireScope: false
+          # If `subjectPattern` is configured, you can use this property to override
+          # the default error message that is shown when the pattern doesn't match.
+          # The variables `subject` and `title` can be used within the message.
+          subjectPatternError: |
+            The subject "{subject}" found in the pull request title "{title}"
+            didn't match the configured pattern. Please ensure that the subject
+            starts with an uppercase character.
+          # For work-in-progress PRs you can typically use draft pull requests
+          # from Github. However, private repositories on the free plan don't have
+          # this option and therefore this action allows you to opt-in to using the
+          # special "[WIP]" prefix to indicate this state. This will avoid the
+          # validation of the PR title and the pull request checks remain pending.
+          # Note that a second check will be reported if this is enabled.
+          wip: true
+          # When using "Squash and merge" on a PR with only one commit, GitHub
+          # will suggest using that commit message instead of the PR title for the
+          # merge commit, and it's easy to commit this by mistake. Enable this option
+          # to also validate the commit message for one commit PRs.
+          validateSingleCommit: false

.github/workflows/pr-title.yml

@@ -10,14 +10,21 @@ on:
         description: Is this a pre-release
         required: true
         default: true
+        type: boolean
       publish:
         description: Publish release
         required: false
         default: false
+        type: boolean
       bump:
         description: 'Bumping (#major, #minor or #patch)'
         required: false
         default: patch
+        type: choice
+        options:
+        - 'patch'
+        - 'minor'
+        - 'major'
 
 jobs:
   draft-a-release:

.github/workflows/release.draft.yml

@@ -16,13 +16,9 @@ repos:
   - id: check-merge-conflict
   - id: detect-aws-credentials
     args: ['--allow-missing-credentials']
-- repo: git://github.com/antonbabenko/pre-commit-terraform
+- repo: https://github.com/antonbabenko/pre-commit-terraform
   rev: v1.70.1
   hooks:
   - id: terraform_fmt
   - id: terraform_docs
   - id: terraform_tflint
-- repo: git://github.com/smian/pre-commit-makefile
-  rev: 261f8fb4b31dfdc05d1a1d7fbde1f1462ecde66d
-  hooks:
-  - id: makefile-doc

.pre-commit-config.yaml

@@ -1,37 +1,48 @@
+config {
+  module = false
+}
+
 plugin "aws" {
   enabled = true
-  deep_check = true
+  version = "0.13.3"
+  source  = "github.com/terraform-linters/tflint-ruleset-aws"
 }
 
-rule "terraform_documented_variables" {
+rule "terraform_comment_syntax" {
   enabled = true
 }
 
-rule "terraform_documented_outputs" {
+rule "terraform_deprecated_index" {
   enabled = true
 }
 
-rule "terraform_comment_syntax" {
+rule "terraform_deprecated_interpolation" {
   enabled = true
 }
 
-rule "terraform_naming_convention" {
+rule "terraform_documented_outputs" {
   enabled = true
 }
 
-rule "terraform_deprecated_interpolation" {
+rule "terraform_documented_variables" {
   enabled = true
 }
 
-rule "terraform_deprecated_index" {
+rule "terraform_module_pinned_source" {
+  enabled = true
+  style = "flexible"
+}
+
+rule "terraform_module_version" {
   enabled = true
 }
 
-rule "terraform_required_providers" {
+rule "terraform_naming_convention" {
   enabled = true
+  format  = "snake_case"
 }
 
-rule "terraform_required_version" {
+rule "terraform_standard_module_structure" {
   enabled = true
 }
 
@@ -42,3 +53,7 @@ rule "terraform_typed_variables" {
 rule "terraform_unused_declarations" {
   enabled = true
 }
+
+rule "terraform_unused_required_providers" {
+  enabled = true
+}

.tflint.hcl

@@ -2,6 +2,8 @@
 
 Terraform module `terraform-aws-enforce-mfa`
 
+---
+
 [![](https://img.shields.io/github/license/terraform-module/terraform-aws-enforce-mfa)](https://github.com/terraform-module/terraform-aws-enforce-mfa)
 ![](https://img.shields.io/github/v/tag/terraform-module/terraform-aws-enforce-mfa)
 [![](https://img.shields.io/github/workflow/status/terraform-module/terraform-aws-enforce-mfa/commit-check/master)](https://github.com/terraform-module/terraform-aws-enforce-mfa/actions?query=is%3Acompleted)
@@ -18,6 +20,8 @@ Terraform module `terraform-aws-enforce-mfa`
 ![](https://img.shields.io/github/last-commit/terraform-module/terraform-aws-enforce-mfa)
 [![Maintenance](https://img.shields.io/badge/Maintenu%3F-oui-green.svg)](https://GitHub.com/terraform-module/terraform-aws-enforce-mfa/graphs/commit-activity)
 
+---
+
 ## Documentations
 
 - [aws-vault setup](https://github.com/99designs/aws-vault)
@@ -59,7 +63,7 @@ resource aws_iam_group support {
 
 module enforce_mfa {
   source  = "terraform-module/enforce-mfa/aws"
-  version = "0.12.0"
+  version = "~> 1.0"
 
   policy_name                     = "managed-mfa-enforce"
   account_id                      = data.aws_caller_identity.current.id
@@ -130,9 +134,9 @@ No modules.
 
 <!-- START makefile-doc -->
 ```
-$ make help 
+$ make help
 hooks                          Commit hooks setup
-validate                       Validate with pre-commit hooks 
+validate                       Validate with pre-commit hooks
 ```
 <!-- END makefile-doc -->
 

README.md

@@ -1,12 +1,12 @@
-data aws_caller_identity current {}
+data "aws_caller_identity" "current" {}
 
-resource aws_iam_group support {
+resource "aws_iam_group" "support" {
   name = "support"
 }
 
-module enforce_mfa {
+module "enforce_mfa" {
   source  = "terraform-module/enforce-mfa/aws"
-  version = "0.12.0"
+  version = "~> 1.0"
 
   policy_name                     = "managed-mfa-enforce"
   account_id                      = data.aws_caller_identity.current.id