Skip to content

Conversation

@j0can
Copy link
Contributor

@j0can j0can commented Mar 10, 2025

↪️ Pull Request

  • Make sure you are opening from a feature/feat/docs/fix/bug/hotfix/stable/chore (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry

📒 Description

The current default value of force_update = true in this module which can cause unintended issues for some Helm charts. In my experience, forcing an update on a Helm release resulted in errors, as seen in this issue: GitHub Issue #438

Based on the terraform provider force_update is by default set to false, and having force update defaults to true for all helm releases could cause issue imo.
https://registry.terraform.io/providers/hashicorp/helm/latest/docs/resources/release

🕶️ Types of changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation
  • Dependencies

🤯 List of changes

👫 Relationships

🔎 Review hints

🚨 Test instructions

Checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • Added/updated unit tests for this change
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).
  • Filled out test instructions (In case there aren't any unit tests)
  • I followed the existing code standards and didn't mess up the formatting.
  • My change requires a change to the documentation.
  • I did my best to add documentation to any public classes or methods I added.
  • Included links to related issues/PRs

@j0can
Copy link
Contributor Author

j0can commented Mar 10, 2025

Also to point that it would be nice to have description field to the helm_release resource, i can add that to this PR if thats ok?

description                = lookup(var.app, "description", null)

@j0can
Copy link
Contributor Author

j0can commented Mar 19, 2025

bump

@stale
Copy link

stale bot commented Jun 18, 2025

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. To track this PR (even if closed), please open a corresponding issue if one does not already exist.

@stale stale bot added the stale label Jun 18, 2025
@ivankatliarchuk
Copy link
Member

Ups. Sorry have not seen this PR

@ivankatliarchuk ivankatliarchuk merged commit 644a8cb into terraform-module:master Jul 2, 2025
6 checks passed
@stale stale bot removed the stale label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants