fix: sonar issues (#3073)

* chore: replace Docker login script with docker/login-action@v3 in release workflows

- Simplified Docker Hub authentication setup by using the `docker/login-action@v3`.
- Updated `setup-buildx-action` to a specific commit reference.
- Added `env` for secrets in image deletion step.

* chore: update pull request workflow to use Yarn caching and scripts

- Switched dependency cache from npm to Yarn for consistent package management.
- Updated dependency installation step to ignore scripts.
- Replaced npm build command with Yarn build for application build step.

Author: alfespa17

.github/workflows/pull_request_ui.yml

@@ -27,11 +27,11 @@ jobs:
         uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
-          cache: "npm"
-          cache-dependency-path: ui/package.json
+          cache: "yarn"
+          cache-dependency-path: ui/yarn.lock
 
       - name: "Install dependencies"
-        run: yarn install --frozen-lockfile
+        run: yarn install --frozen-lockfile --ignore-scripts
 
       - name: "Check linting"
         run: yarn lint:modules:check
@@ -40,6 +40,6 @@ jobs:
         run: yarn format:modules:check
 
       - name: "Build application"
-        run: npm run build --if-present
+        run: yarn build
         env:
           CI: false

.github/workflows/release.yml

@@ -33,10 +33,11 @@ jobs:
       with:
         node-version: 22
 
-    - name: Set up Docker config
-      run: |
-        mkdir -p ~/.docker
-        echo '{"auths":{"https://index.docker.io/v1/":{"auth":"'$(echo -n "${{ secrets.DOCKER_USER }}:${{ secrets.DOCKER_PASSWORD }}" | base64 )'"}}}' > ~/.docker/config.json
+    - name: Login to Docker Hub
+      uses: docker/login-action@v3
+      with:
+        username: ${{ secrets.DOCKER_USER }}
+        password: ${{ secrets.DOCKER_PASSWORD }}
 
     - name: Set environment label for Alpaquita
       if: matrix.os == 'alpaquita'
@@ -109,13 +110,14 @@ jobs:
     env:
       VERSION: ${{ github.event.release.tag_name }}
     steps:
-    - name: Set up Docker config
-      run: |
-        mkdir -p ~/.docker
-        echo '{"auths":{"https://index.docker.io/v1/":{"auth":"'$(echo -n "${{ secrets.DOCKER_USER }}:${{ secrets.DOCKER_PASSWORD }}" | base64 )'"}}}' > ~/.docker/config.json
+    - name: Login to Docker Hub
+      uses: docker/login-action@v3
+      with:
+        username: ${{ secrets.DOCKER_USER }}
+        password: ${{ secrets.DOCKER_PASSWORD }}
 
     - name: Set up Docker Buildx
-      uses: docker/setup-buildx-action@v3
+      uses: docker/setup-buildx-action@b5ca514318bd6ebac0fb2aedd5d36ec1b5c232a2 # v3.10.0
 
     - name: Create and Push Multi-Platform Images
       run: |
@@ -149,8 +151,6 @@ jobs:
 
     - name: Delete ARM Images
       run: |
-          USERNAME="${{ secrets.DOCKER_USER }}"
-          PASSWORD="${{ secrets.DOCKER_PASSWORD }}"
           ORGANIZATION="azbuilder"
           IMAGES=("api-server" "open-registry" "executor" "terrakube-ui")
           TAG="${{ env.VERSION }}-arm"
@@ -176,4 +176,7 @@ jobs:
             else
               echo "Failed to delete ${ORGANIZATION}/${IMAGE}:${TAG}. HTTP status code: $DELETE_RESPONSE"
             fi
-          done
+          done
+      env:
+        USERNAME: ${{ secrets.DOCKER_USER }}
+        PASSWORD: ${{ secrets.DOCKER_PASSWORD }}