Require Ruby 3.1+ and modernize CI

- Set required_ruby_version to ">= 3.1" in the gemspec
- Standardize .rubocop.yml on cookstyle/chefstyle with TargetRubyVersion 3.1
  (the standalone `chefstyle` gem no longer loads, which broke linting)
- Run unit tests on every Ruby release from 3.1 to 4.0 and run
  cookstyle --chefstyle on Ruby 3.1
- Add the cookstyle bundler group where it was missing so
  `bundle exec cookstyle` resolves in CI
- Apply cookstyle --chefstyle autocorrections
- Drop dead linters (cane, tailor, finstyle, standalone chefstyle) that
  are superseded by cookstyle and fail on modern Ruby

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Tim Smith <tsmith84@proton.me>

Author: tas50

.github/workflows/lint.yml

@@ -0,0 +1,9 @@
+---
+name: "Test"
+
+"on":
+  pull_request:
+
+jobs:
+  lint-unit:
+    uses: test-kitchen/.github/.github/workflows/lint-unit.yml@main

.rubocop.yml

@@ -0,0 +1,11 @@
+---
+require:
+  - cookstyle/chefstyle
+
+AllCops:
+  TargetRubyVersion: 3.1
+  Include:
+    - "**/*.rb"
+  Exclude:
+    - "vendor/**/*"
+    - "spec/**/*"

Gemfile

@@ -7,3 +7,7 @@ group :guard do
   gem 'guard-cucumber'
   gem 'guard-cane'
 end
+
+group :cookstyle do
+  gem "cookstyle"
+end

Rakefile

@@ -1,7 +1,6 @@
 require "bundler/gem_tasks"
 require 'rake/testtask'
 require 'cucumber/rake/task'
-require 'cane/rake_task'
 
 Rake::TestTask.new(:unit) do |t|
   t.libs.push "lib"
@@ -16,10 +15,6 @@ end
 desc "Run all test suites"
 task :test => [:unit, :features]
 
-desc "Run cane to check quality metrics"
-Cane::RakeTask.new do |cane|
-  cane.canefile = './.cane'
-end
 
 desc "Display LOC stats"
 task :stats do
@@ -30,6 +25,6 @@ task :stats do
 end
 
 desc "Run all quality tasks"
-task :quality => [:cane, :stats]
+task :quality => [:stats]
 
 task :default => [:test, :quality]

bin/busser

@@ -1,8 +1,6 @@
 #!/usr/bin/env ruby
-# -*- encoding: utf-8 -*-
-
 $:.unshift File.join(File.dirname(__FILE__), %w{.. lib})
-require 'rubygems' unless defined?(Gem)
-require 'busser/cli'
+require "rubygems" unless defined?(Gem)
+require "busser/cli"
 
 Busser::CLI.start

busser.gemspec

@@ -18,13 +18,12 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.required_ruby_version = ">= 1.9.1"
+  spec.required_ruby_version = ">= 3.1"
 
   spec.add_dependency 'thor', '<= 1.1.0'
 
   spec.add_development_dependency 'aruba', "0.7.4"
   spec.add_development_dependency "bundler"
-  spec.add_development_dependency 'cane'
   spec.add_development_dependency 'countloc'
   spec.add_development_dependency 'fakefs'
   spec.add_development_dependency 'minitest'

features/support/env.rb

@@ -1,8 +1,8 @@
-require 'aruba/cucumber'
-require 'busser/cucumber'
+require "aruba/cucumber"
+require "busser/cucumber"
 
 if ENV["COVERAGE"]
-  require 'simplecov'
+  require "simplecov"
   SimpleCov.command_name "features"
 end
 

lib/busser.rb

@@ -1,4 +1,3 @@
-# -*- encoding: utf-8 -*-
 #
 # Author:: Fletcher Nichol (<fnichol@nichol.ca>)
 #
@@ -16,9 +15,9 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-require 'pathname' unless defined?(Pathname)
+require "pathname" unless defined?(Pathname)
 
-require 'busser/version'
+require "busser/version"
 
 # Busser - Runs tests for projects in Test Kitchen.
 #
@@ -30,6 +29,6 @@ module Busser
   #
   # @return [Pathname] root path of gem
   def self.source_root
-    @source_root ||= Pathname.new(File.expand_path('../../', __FILE__))
+    @source_root ||= Pathname.new(File.expand_path("..", __dir__))
   end
 end

lib/busser/cli.rb

@@ -1,4 +1,3 @@
-# -*- encoding: utf-8 -*-
 #
 # Author:: Fletcher Nichol (<fnichol@nichol.ca>)
 #
@@ -16,12 +15,12 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-require 'busser/thor'
-require 'busser/command/deserialize'
-require 'busser/command/plugin'
-require 'busser/command/setup'
-require 'busser/command/suite'
-require 'busser/command/test'
+require "busser/thor"
+require "busser/command/deserialize"
+require "busser/command/plugin"
+require "busser/command/setup"
+require "busser/command/suite"
+require "busser/command/test"
 
 module Busser
 

lib/busser/command/deserialize.rb

@@ -1,4 +1,3 @@
-# -*- encoding: utf-8 -*-
 #
 # Author:: Fletcher Nichol (<fnichol@nichol.ca>)
 #
@@ -16,10 +15,10 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-require 'base64' unless defined?(Base64)
-require 'digest' unless defined?(Digest)
+require "base64" unless defined?(Base64)
+require "digest" unless defined?(Digest)
 
-require 'busser/thor'
+require "busser/thor"
 
 module Busser
 
@@ -31,11 +30,11 @@ module Command
     #
     class Deserialize < Busser::Thor::BaseGroup
 
-      class_option :destination, :desc => "Destination file path"
+      class_option :destination, desc: "Destination file path"
 
-      class_option :md5sum, :desc => "MD5 digest of original file"
+      class_option :md5sum, desc: "MD5 digest of original file"
 
-      class_option :perms, :desc => "Unix permissions on destination file"
+      class_option :perms, desc: "Unix permissions on destination file"
 
       def perform
         file = File.expand_path(options[:destination])