fix: switch to cookstyle (#233)

* fix: switch to cookstyle

Signed-off-by: Corey Hemminger <hemminger@hotmail.com>

* Update .rubocop.yml to cookstyle

Signed-off-by: Corey Hemminger <hemminger@hotmail.com>

* Update Rakefile for cookstyle

Signed-off-by: Corey Hemminger <hemminger@hotmail.com>

* lint fixes

Signed-off-by: Corey Hemminger <hemminger@hotmail.com>

---------

Signed-off-by: Corey Hemminger <hemminger@hotmail.com>

Author: Stromweld

.rubocop.yml

@@ -1,6 +1,6 @@
 ---
 require:
-  - chefstyle
+  - cookstyle
 
 AllCops:
   TargetRubyVersion: 3.1

Gemfile

@@ -16,6 +16,6 @@ group :debug do
   gem "pry"
 end
 
-group :chefstyle do
-  gem "chefstyle", "2.2.3"
+group :cookstyle do
+  gem "cookstyle"
 end

Rakefile

@@ -15,13 +15,13 @@ task :stats do
 end
 
 begin
-  require "chefstyle"
+  require "cookstyle"
   require "rubocop/rake_task"
   RuboCop::RakeTask.new(:style) do |task|
-    task.options += ["--display-cop-names", "--no-color"]
+    task.options += ["--chefstyle", "--display-cop-names", "--no-color"]
   end
 rescue LoadError
-  puts "chefstyle is not available.  gem install chefstyle to do style checking."
+  puts "cookstyle is not available.  gem install cookstyle to do style checking."
 end
 
 desc "Run all quality tasks"

lib/kitchen/driver/openstack.rb

@@ -178,12 +178,12 @@ def create_server
         raise(ActionFailed, "Cannot specify both network_ref and network_id") if config[:network_id] && config[:network_ref]
 
         if config[:network_id]
-          networks = [].concat([config[:network_id]])
+          networks = [].push(config[:network_id])
           server_def[:nics] = networks.flatten.map do |net_id|
             { "net_id" => net_id }
           end
         elsif config[:network_ref]
-          networks = [].concat([config[:network_ref]])
+          networks = [].push(config[:network_ref])
           server_def[:nics] = networks.flatten.map do |net|
             { "net_id" => find_network(net).id }
           end