Skip to content
This repository was archived by the owner on Aug 26, 2025. It is now read-only.

Commit 81beaef

Browse files
scbeddscbedd
committed
cutover PR
1 parent 061f4e9 commit 81beaef

13 files changed

+63
-61
lines changed

‎.github/workflows/src/summarize-checks/summarize-checks.js‎

Lines changed: 27 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@
1919
*/
2020

2121
// #region imports/constants
22-
import { extractInputs } from "../context.js";
23-
// import { commentOrUpdate } from "../comment.js";
2422
import { execFile } from "../../../shared/src/exec.js";
2523
import { CheckConclusion, PER_PAGE_MAX } from "../../../shared/src/github.js";
2624
import { intersect } from "../../../shared/src/set.js";
25+
import { commentOrUpdate } from "../comment.js";
26+
import { extractInputs } from "../context.js";
2727
import {
2828
brChRevApproval,
2929
getViolatedRequiredLabelsRules,
@@ -140,7 +140,8 @@ const FYI_CHECK_NAMES = [
140140
"Swagger BreakingChange",
141141
"Swagger PrettierCheck",
142142
];
143-
const AUTOMATED_CHECK_NAME = "[TEST-IGNORE] Automated merging requirements met";
143+
const AUTOMATED_CHECK_NAME = "Automated merging requirements met";
144+
const IMPACT_CHECK_NAME = "Summarize PR Impact";
144145
const NEXT_STEPS_COMMENT_ID = "NextStepsToMerge";
145146

146147
/** @type {CheckMetadata[]} */
@@ -397,24 +398,24 @@ export async function summarizeChecksImpl(
397398

398399
for (const label of labelContext.toRemove) {
399400
core.info(`Removing label: ${label} from ${owner}/${repo}#${issue_number}.`);
400-
// await github.rest.issues.removeLabel({
401-
// owner: owner,
402-
// repo: repo,
403-
// issue_number: issue_number,
404-
// name: label,
405-
// });
401+
await github.rest.issues.removeLabel({
402+
owner: owner,
403+
repo: repo,
404+
issue_number: issue_number,
405+
name: label,
406+
});
406407
}
407408

408409
if (labelContext.toAdd.size > 0) {
409410
core.info(
410411
`Adding labels: ${Array.from(labelContext.toAdd).join(", ")} to ${owner}/${repo}#${issue_number}.`,
411412
);
412-
// await github.rest.issues.addLabels({
413-
// owner: owner,
414-
// repo: repo,
415-
// issue_number: issue_number,
416-
// labels: Array.from(labelContext.toAdd),
417-
// });
413+
await github.rest.issues.addLabels({
414+
owner: owner,
415+
repo: repo,
416+
issue_number: issue_number,
417+
labels: Array.from(labelContext.toAdd),
418+
});
418419
}
419420

420421
// adjust labelNames based on labelsToAdd/labelsToRemove
@@ -441,20 +442,21 @@ export async function summarizeChecksImpl(
441442
`Updating comment '${NEXT_STEPS_COMMENT_ID}' on ${owner}/${repo}#${issue_number} with body: ${commentBody}`,
442443
);
443444
// this will remain commented until we're comfortable with the change.
444-
// await commentOrUpdate(
445-
// { github, context, core },
446-
// owner,
447-
// repo,
448-
// issue_number,
449-
// commentName,
450-
// commentBody
451-
// )
445+
await commentOrUpdate(
446+
github,
447+
core,
448+
owner,
449+
repo,
450+
issue_number,
451+
commentBody,
452+
NEXT_STEPS_COMMENT_ID,
453+
);
452454

453455
// finally, update the "Automated merging requirements met" commit status
454456
await updateCommitStatus(github, core, owner, repo, head_sha, automatedChecksMet);
455457

456458
core.info(
457-
`Summarize checks has identified that status of "[TEST-IGNORE] Automated merging requirements met" commit status should be updated to: ${JSON.stringify(automatedChecksMet)}.`,
459+
`Summarize checks has identified that status of "${AUTOMATED_CHECK_NAME}" commit status should be updated to: ${JSON.stringify(automatedChecksMet)}.`,
458460
);
459461
}
460462

@@ -831,7 +833,7 @@ export function extractRunsFromGraphQLResponse(response) {
831833
if (checkSuiteNode.checkRuns?.nodes) {
832834
checkSuiteNode.checkRuns.nodes.forEach((checkRunNode) => {
833835
if (
834-
checkRunNode.name === "[TEST-IGNORE] Summarize PR Impact" &&
836+
checkRunNode.name === IMPACT_CHECK_NAME &&
835837
checkRunNode.status?.toLowerCase() === "completed" &&
836838
checkRunNode.conclusion?.toLowerCase() === "success"
837839
) {

‎.github/workflows/summarize-checks.yaml‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
name: "[TEST-IGNORE] Summarize Checks"
1+
name: "Summarize Checks"
22

33
on:
44
workflow_run:
55
workflows:
6-
- "\\[TEST-IGNORE\\] Swagger SemanticValidation - Set Status"
7-
- "\\[TEST-IGNORE\\] Swagger ModelValidation - Set Status"
8-
- "\\[TEST-IGNORE\\] Summarize PR Impact"
6+
- "Swagger SemanticValidation - Set Status"
7+
- "Swagger ModelValidation - Set Status"
8+
- "Summarize PR Impact"
99
- "Swagger Avocado - Set Status"
1010
- "Swagger LintDiff - Set Status"
1111
- "SDK Validation Status"
@@ -30,7 +30,7 @@ permissions:
3030
jobs:
3131
run-summarize-checks:
3232
if: ${{ github.event_name == 'pull_request_target' || github.event.workflow_run.conclusion != 'skipped' }}
33-
name: "[TEST-IGNORE] Summarize Checks"
33+
name: "Summarize Checks"
3434
runs-on: ubuntu-24.04
3535

3636
steps:

‎.github/workflows/summarize-impact.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: "[TEST-IGNORE] Summarize PR Impact"
1+
name: "Summarize PR Impact"
22

33
on: pull_request
44

@@ -8,7 +8,7 @@ permissions:
88

99
jobs:
1010
impact:
11-
name: "[TEST-IGNORE] Summarize PR Impact"
11+
name: "Summarize PR Impact"
1212
runs-on: ubuntu-24.04
1313

1414
steps:

‎.github/workflows/swagger-modelvalidation-code.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: "[TEST-IGNORE] Swagger ModelValidation - Analyze Code"
1+
name: "Swagger ModelValidation - Analyze Code"
22

33
on: pull_request
44

@@ -7,7 +7,7 @@ permissions:
77

88
jobs:
99
oav:
10-
name: "[TEST-IGNORE] Swagger ModelValidation - Analyze Code"
10+
name: "Swagger ModelValidation - Analyze Code"
1111
runs-on: ubuntu-24.04
1212

1313
steps:

‎.github/workflows/swagger-modelvalidation-status.yaml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: "[TEST-IGNORE] Swagger ModelValidation - Set Status"
1+
name: "Swagger ModelValidation - Set Status"
22

33
on:
44
# Must run on pull_request_target instead of pull_request, since the latter cannot trigger on
@@ -15,7 +15,7 @@ on:
1515
- labeled
1616
- unlabeled
1717
workflow_run:
18-
workflows: ["\\[TEST-IGNORE\\] Swagger ModelValidation - Analyze Code"]
18+
workflows: ["Swagger ModelValidation - Analyze Code"]
1919
types: [completed]
2020

2121
permissions:
@@ -30,6 +30,6 @@ jobs:
3030
name: Set ModelValidation Status
3131
uses: ./.github/workflows/_reusable-set-check-status.yaml
3232
with:
33-
monitored_workflow_name: "[TEST-IGNORE] Swagger ModelValidation - Analyze Code"
34-
required_check_name: "[TEST-IGNORE] Swagger ModelValidation"
33+
monitored_workflow_name: "Swagger ModelValidation - Analyze Code"
34+
required_check_name: "Swagger ModelValidation"
3535
overriding_label: "Approved-ModelValidation"

‎.github/workflows/swagger-semanticvalidation-code.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: "[TEST-IGNORE] Swagger SemanticValidation - Analyze Code"
1+
name: "Swagger SemanticValidation - Analyze Code"
22

33
on: pull_request
44

@@ -7,7 +7,7 @@ permissions:
77

88
jobs:
99
oav:
10-
name: "[TEST-IGNORE] Swagger SemanticValidation - Analyze Code"
10+
name: "Swagger SemanticValidation - Analyze Code"
1111
runs-on: ubuntu-24.04
1212

1313
steps:

‎.github/workflows/swagger-semanticvalidation-status.yaml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: "[TEST-IGNORE] Swagger SemanticValidation - Set Status"
1+
name: "Swagger SemanticValidation - Set Status"
22

33
on:
44
# Must run on pull_request_target instead of pull_request, since the latter cannot trigger on
@@ -15,7 +15,7 @@ on:
1515
- labeled
1616
- unlabeled
1717
workflow_run:
18-
workflows: ["\\[TEST-IGNORE\\] Swagger SemanticValidation - Analyze Code"]
18+
workflows: ["Swagger SemanticValidation - Analyze Code"]
1919
types: [completed]
2020

2121
permissions:
@@ -30,6 +30,6 @@ jobs:
3030
name: Set SemanticValidation Status
3131
uses: ./.github/workflows/_reusable-set-check-status.yaml
3232
with:
33-
monitored_workflow_name: "[TEST-IGNORE] Swagger SemanticValidation - Analyze Code"
34-
required_check_name: "[TEST-IGNORE] Swagger SemanticValidation"
33+
monitored_workflow_name: "Swagger SemanticValidation - Analyze Code"
34+
required_check_name: "Swagger SemanticValidation"
3535
overriding_label: "Approved-SemanticValidation"

‎.github/workflows/test/summarize-checks/fixtures/RawGraphQLResponse.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -339,13 +339,13 @@
339339
"id": "WFR_kwLOAlSEjc8AAAAD3GhuLA",
340340
"databaseId": 16582733356,
341341
"workflow": {
342-
"name": "[TEST-IGNORE] Summarize PR Impact"
342+
"name": "Summarize PR Impact"
343343
}
344344
},
345345
"checkRuns": {
346346
"nodes": [
347347
{
348-
"name": "[TEST-IGNORE] Summarize PR Impact",
348+
"name": "Summarize PR Impact",
349349
"status": "COMPLETED",
350350
"conclusion": "SUCCESS",
351351
"isRequired": false

‎.github/workflows/test/summarize-checks/summarize-checks.test.js‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ describe("Summarize Checks Unit Tests", () => {
146146
const expectedOutput = [
147147
expectedComment,
148148
{
149-
name: "[TEST-IGNORE] Automated merging requirements met",
149+
name: "Automated merging requirements met",
150150
result: "FAILURE",
151151
summary:
152152
"❌ This PR cannot be merged because some requirements are not met. See the details.",
@@ -256,7 +256,7 @@ describe("Summarize Checks Unit Tests", () => {
256256
const expectedOutput = [
257257
'<h2>Next Steps to Merge</h2>✅ All automated merging requirements have been met! To get your PR merged, see <a href="https://aka.ms/azsdk/specreview/merge">aka.ms/azsdk/specreview/merge</a>.',
258258
{
259-
name: "[TEST-IGNORE] Automated merging requirements met",
259+
name: "Automated merging requirements met",
260260
result: "SUCCESS",
261261
summary: `✅ All automated merging requirements have been met.<br/>To merge this PR, refer to <a href="https://aka.ms/azsdk/specreview/merge">aka.ms/azsdk/specreview/merge</a>.<br/>For help, consult comments on this PR and see [aka.ms/azsdk/pr-getting-help](https://aka.ms/azsdk/pr-getting-help).`,
262262
},
@@ -283,7 +283,7 @@ describe("Summarize Checks Unit Tests", () => {
283283
const expectedOutput = [
284284
'<h2>Next Steps to Merge</h2>✅ All automated merging requirements have been met! To get your PR merged, see <a href="https://aka.ms/azsdk/specreview/merge">aka.ms/azsdk/specreview/merge</a>.',
285285
{
286-
name: "[TEST-IGNORE] Automated merging requirements met",
286+
name: "Automated merging requirements met",
287287
result: "SUCCESS",
288288
summary: `✅ All automated merging requirements have been met.<br/>To merge this PR, refer to <a href="https://aka.ms/azsdk/specreview/merge">aka.ms/azsdk/specreview/merge</a>.<br/>For help, consult comments on this PR and see [aka.ms/azsdk/pr-getting-help](https://aka.ms/azsdk/pr-getting-help).`,
289289
},
@@ -391,7 +391,7 @@ describe("Summarize Checks Unit Tests", () => {
391391
const expectedOutput = [
392392
"<h2>Next Steps to Merge</h2>⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛",
393393
{
394-
name: "[TEST-IGNORE] Automated merging requirements met",
394+
name: "Automated merging requirements met",
395395
result: "pending",
396396
summary: "The requirements for merging this PR are still being evaluated. Please wait.",
397397
},
@@ -499,7 +499,7 @@ describe("Summarize Checks Unit Tests", () => {
499499
const expectedOutput = [
500500
"<h2>Next Steps to Merge</h2>⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛",
501501
{
502-
name: "[TEST-IGNORE] Automated merging requirements met",
502+
name: "Automated merging requirements met",
503503
result: "pending",
504504
summary: "The requirements for merging this PR are still being evaluated. Please wait.",
505505
},
@@ -564,7 +564,7 @@ describe("Summarize Checks Unit Tests", () => {
564564
const expectedOutput = [
565565
'<h2>Next Steps to Merge</h2>✅ All automated merging requirements have been met! To get your PR merged, see <a href="https://aka.ms/azsdk/specreview/merge">aka.ms/azsdk/specreview/merge</a>.',
566566
{
567-
name: "[TEST-IGNORE] Automated merging requirements met",
567+
name: "Automated merging requirements met",
568568
result: "SUCCESS",
569569
summary: `✅ All automated merging requirements have been met.<br/>To merge this PR, refer to <a href="https://aka.ms/azsdk/specreview/merge">aka.ms/azsdk/specreview/merge</a>.<br/>For help, consult comments on this PR and see [aka.ms/azsdk/pr-getting-help](https://aka.ms/azsdk/pr-getting-help).`,
570570
},
@@ -635,7 +635,7 @@ describe("Summarize Checks Unit Tests", () => {
635635
const expectedOutput = [
636636
'<h2>Next Steps to Merge</h2>✅ All automated merging requirements have been met! To get your PR merged, see <a href="https://aka.ms/azsdk/specreview/merge">aka.ms/azsdk/specreview/merge</a>.',
637637
{
638-
name: "[TEST-IGNORE] Automated merging requirements met",
638+
name: "Automated merging requirements met",
639639
result: "SUCCESS",
640640
summary: `✅ All automated merging requirements have been met.<br/>To merge this PR, refer to <a href="https://aka.ms/azsdk/specreview/merge">aka.ms/azsdk/specreview/merge</a>.<br/>For help, consult comments on this PR and see [aka.ms/azsdk/pr-getting-help](https://aka.ms/azsdk/pr-getting-help).`,
641641
},
@@ -691,7 +691,7 @@ describe("Summarize Checks Unit Tests", () => {
691691
const expectedOutput = [
692692
"<h2>Next Steps to Merge</h2>⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛",
693693
{
694-
name: "[TEST-IGNORE] Automated merging requirements met",
694+
name: "Automated merging requirements met",
695695
result: "pending",
696696
summary: "The requirements for merging this PR are still being evaluated. Please wait.",
697697
},
@@ -739,7 +739,7 @@ describe("Summarize Checks Unit Tests", () => {
739739
const expectedOutput = [
740740
"<h2>Next Steps to Merge</h2>⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛",
741741
{
742-
name: "[TEST-IGNORE] Automated merging requirements met",
742+
name: "Automated merging requirements met",
743743
result: "pending",
744744
summary: "The requirements for merging this PR are still being evaluated. Please wait.",
745745
},
@@ -784,7 +784,7 @@ describe("Summarize Checks Unit Tests", () => {
784784
const targetBranch = "main";
785785
const labelNames = [];
786786
const expectedCheckOutput = {
787-
name: "[TEST-IGNORE] Automated merging requirements met",
787+
name: "Automated merging requirements met",
788788
result: "FAILURE",
789789
summary:
790790
"❌ This PR cannot be merged because some requirements are not met. See the details.",
@@ -827,7 +827,7 @@ describe("Summarize Checks Unit Tests", () => {
827827
const labelNames = [];
828828
const fyiCheckRuns = [];
829829
const expectedCheckOutput = {
830-
name: "[TEST-IGNORE] Automated merging requirements met",
830+
name: "Automated merging requirements met",
831831
result: "FAILURE",
832832
summary:
833833
"❌ This PR cannot be merged because some requirements are not met. See the details.",

‎.github/workflows/watch-breakingchange-crossversion.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,4 @@ jobs:
2424
uses: ./.github/workflows/_reusable-verify-run-status.yaml
2525
with:
2626
check_run_name: "Breaking Change(Cross-Version)"
27-
commit_status_name: "[TEST-IGNORE] Breaking Change(Cross-Version)"
27+
commit_status_name: "Breaking Change(Cross-Version)"

0 commit comments

Comments
 (0)