Fix quantum status readonly bug (Azure#32494)

* Fix quantum status readonly bug

* Fix format

* Use built-in tags feature

Author: xinyi-joffre

specification/quantum/Microsoft.Quantum.Management/QuantumWorkspace.tsp

@@ -44,8 +44,7 @@ interface Workspaces {
   /**
    * Updates an existing Workspace's tags.
    */
-  @parameterVisibility
-  updateTags is ArmCustomPatchSync<QuantumWorkspace, PatchModel = TagsObject>;
+  updateTags is ArmTagsPatchSync<QuantumWorkspace>;
 
   /**
    * Deletes a Workspace resource.

specification/quantum/Microsoft.Quantum.Management/models.tsp

@@ -437,47 +437,6 @@ model Provider {
   resourceUsageId?: string;
 }
 
-/**
- * Common fields that are returned in the response for all Azure Resource Manager resources
- */
-model Resource {
-  /**
-   * Fully qualified resource ID for the resource. E.g. "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{resourceType}/{resourceName}"
-   */
-  @visibility("read")
-  id?: Azure.Core.armResourceIdentifier;
-
-  /**
-   * The name of the resource
-   */
-  @visibility("read")
-  name?: string;
-
-  /**
-   * The type of the resource. E.g. "Microsoft.Compute/virtualMachines" or "Microsoft.Storage/storageAccounts"
-   */
-  @visibility("read")
-  type?: string;
-
-  /**
-   * Azure Resource Manager metadata containing createdBy and modifiedBy information.
-   */
-  @visibility("read")
-  systemData?: SystemData;
-}
-
-/**
- * Tags object for patch operations.
- */
-#suppress "@azure-tools/typespec-azure-resource-manager/patch-envelope" ""
-model TagsObject {
-  /**
-   * Resource tags.
-   */
-  #suppress "@azure-tools/typespec-azure-resource-manager/arm-no-record" ""
-  tags?: Record<string>;
-}
-
 /**
  * Result of list Api keys and connection strings.
  */

specification/quantum/Microsoft.Quantum.Management/tspconfig.yaml

@@ -2,7 +2,7 @@ emit:
   - "@azure-tools/typespec-autorest"
 options:
   "@azure-tools/typespec-autorest":
-    use-read-only-status-schema: true
+    use-read-only-status-schema: false
     omit-unreachable-types: true
     emitter-output-dir: "{project-root}/.."
     azure-resource-provider-folder: "resource-manager"

specification/quantum/resource-manager/Microsoft.Quantum/preview/2023-11-13-preview/quantum.json

@@ -412,7 +412,7 @@
             "description": "Parameters supplied to update tags.",
             "required": true,
             "schema": {
-              "$ref": "#/definitions/TagsObject"
+              "$ref": "#/definitions/QuantumWorkspaceTagsUpdate"
             }
           }
         ],
@@ -918,8 +918,7 @@
             "description": "The provider is failed."
           }
         ]
-      },
-      "readOnly": true
+      }
     },
     "QuantumWorkspace": {
       "type": "object",
@@ -961,6 +960,19 @@
         "value"
       ]
     },
+    "QuantumWorkspaceTagsUpdate": {
+      "type": "object",
+      "description": "The type used for updating tags in QuantumWorkspace resources.",
+      "properties": {
+        "tags": {
+          "type": "object",
+          "description": "Resource tags.",
+          "additionalProperties": {
+            "type": "string"
+          }
+        }
+      }
+    },
     "QuotaDimension": {
       "type": "object",
       "description": "Information about a specific quota dimension.",
@@ -1051,19 +1063,6 @@
         }
       }
     },
-    "TagsObject": {
-      "type": "object",
-      "description": "Tags object for patch operations.",
-      "properties": {
-        "tags": {
-          "type": "object",
-          "description": "Resource tags.",
-          "additionalProperties": {
-            "type": "string"
-          }
-        }
-      }
-    },
     "TargetDescription": {
       "type": "object",
       "description": "Information about a Target. A target is the component that can process a specific type of Job.",
@@ -1178,8 +1177,7 @@
             "description": "The Workspace is currently provisioning a provider."
           }
         ]
-      },
-      "readOnly": true
+      }
     },
     "WorkspaceResourceProperties": {
       "type": "object",

specification/quantum/resource-manager/readme.md

@@ -95,7 +95,7 @@ See configuration in [readme.typescript.md](./readme.typescript.md)
 
 See configuration in [readme.csharp.md](./readme.csharp.md)
 
-## Suppression
+## Suppressions
 
 ``` yaml
 directive:
@@ -108,3 +108,9 @@ directive:
     from: quantum.json
     reason: We don't have end customers making direct API calls and this is a breaking change for our existing clients.
 ```
+
+```yaml
+suppressions:
+  - code: ProvisioningStateMustBeReadOnly
+    reason: The provisioningState being flagged is not the ARM resource provisioningState, but the field for our ProviderStatus. Currently, this cannot be readOnly, or it will cause livesite issue and workspace does not behave correctly. We have on our roadmap to fix this issue, but this needs to be settable for control plane to work properly.
+```