Skip to content

Commit 0dbca5a

Browse files
authored
Removal of dotnet6 (#287)
* Remove .NET 6 support * Update nuget packages * revert build machine * Fix warnings * Update codeql yaml and dependabot config
1 parent 8c33d36 commit 0dbca5a

File tree

9 files changed

+20
-36
lines changed

9 files changed

+20
-36
lines changed

.config/dotnet-tools.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,18 @@
33
"isRoot": true,
44
"tools": {
55
"dotnet-sonarscanner": {
6-
"version": "9.0.0",
6+
"version": "9.0.2",
77
"commands": [
88
"dotnet-sonarscanner"
99
],
1010
"rollForward": false
1111
},
1212
"nbgv": {
13-
"version": "3.6.143",
13+
"version": "3.7.112",
1414
"commands": [
1515
"nbgv"
1616
],
1717
"rollForward": false
1818
}
1919
}
20-
}
20+
}

.github/dependabot.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ updates:
1111
reviewers:
1212
- "dnperfors"
1313
- package-ecosystem: "github-actions"
14-
directory: ".github/"
14+
directory: "/"
1515
schedule:
1616
interval: "daily"
1717
reviewers:

.github/workflows/ci.yml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,8 @@ jobs:
2727
uses: actions/setup-dotnet@v4
2828
with:
2929
dotnet-version: |
30-
6.0.x
3130
8.0.x
3231
9.0.x
33-
include-prerelease: true
3432
- name: Dump .NET info
3533
run: dotnet --info
3634
- name: Restore dotnet tools
@@ -45,7 +43,7 @@ jobs:
4543
- name: Build source code
4644
run: dotnet build --configuration Release --no-restore
4745
- name: Test with dotnet
48-
run: dotnet test --configuration Release --no-build --collect="Code Coverage" --framework="net6.0"
46+
run: dotnet test --configuration Release --no-build --collect="Code Coverage" --framework="net8.0"
4947
- name: Upload sonarqube results
5048
if: ${{ github.actor != 'dependabot[bot]' }}
5149
env:
@@ -69,7 +67,7 @@ jobs:
6967
testOnSupportedDotnetVersions:
7068
strategy:
7169
matrix:
72-
os: [ubuntu-latest, windows-latest]
70+
os: [ubuntu-22.04, windows-latest]
7371
runs-on: ${{ matrix.os }}
7472
steps:
7573
- name: Checkout
@@ -80,10 +78,8 @@ jobs:
8078
uses: actions/setup-dotnet@v4
8179
with:
8280
dotnet-version: |
83-
6.0.x
8481
8.0.x
8582
9.0.x
86-
include-prerelease: true
8783
- name: Dump .NET info
8884
run: dotnet --info
8985
- name: Restore dependencies
@@ -105,7 +101,6 @@ jobs:
105101
with:
106102
dotnet-version: |
107103
9.0.x
108-
include-prerelease: true
109104
- uses: actions/download-artifact@v4
110105
with:
111106
name: artifacts

.github/workflows/codeql.yml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,24 +19,22 @@ jobs:
1919

2020
steps:
2121
- name: Checkout Repository
22-
uses: actions/checkout@v2
22+
uses: actions/checkout@v4
2323
- name: Fetch all history for all tags and branches
2424
run: git fetch --prune --unshallow
2525
- name: Setup .NET versions
26-
uses: actions/setup-dotnet@v1
26+
uses: actions/setup-dotnet@v4
2727
with:
2828
dotnet-version: |
29-
6.0.x
3029
8.0.x
3130
9.0.x
32-
include-prerelease: true
3331
- name: Initialize CodeQL
34-
uses: github/codeql-action/init@v2
32+
uses: github/codeql-action/init@v3
3533
with:
3634
queries: security-and-quality
3735
languages: csharp
3836
config-file: ./.github/codeql-config.yml
3937
- name: Build source code
4038
run: dotnet build --configuration Release --framework net8.0
4139
- name: Perform CodeQL Analysis
42-
uses: github/codeql-action/analyze@v2
40+
uses: github/codeql-action/analyze@v3

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

77
## [0.12] - unplanned
8+
### Removed
9+
- .NET 6.0 target, since it is no longer supported
810
### Added
911
- Support for .NET 9.0
1012

src/TestableHttpClient/TestableHttpClient.csproj

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFrameworks>netstandard2.0;net6.0;net8.0;net9.0</TargetFrameworks>
4+
<TargetFrameworks>netstandard2.0;net8.0;net9.0</TargetFrameworks>
55
</PropertyGroup>
66

77
<PropertyGroup>
@@ -24,7 +24,7 @@
2424
<IncludeSymbols>true</IncludeSymbols>
2525
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
2626
<DebugType>full</DebugType>
27-
27+
2828
<IncludeSource>true</IncludeSource>
2929
<RepositoryUrl>https://github.com/testablehttpclient/TestableHttpClient</RepositoryUrl>
3030
<RepositoryType>git</RepositoryType>
@@ -39,16 +39,12 @@
3939
<PackageReference Include="PolyKit.Embedded" Version="3.0.9" />
4040
</ItemGroup>
4141

42-
<ItemGroup Condition="'$(TargetFramework)' == 'net6.0'">
43-
<PackageReference Include="Perfors.UnreachableException" Version="1.0.0" />
44-
</ItemGroup>
45-
4642
<ItemGroup>
4743
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All" />
4844
<PackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="3.3.4" PrivateAssets="All">
4945
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
5046
</PackageReference>
51-
<PackageReference Include="Nerdbank.GitVersioning" Version="3.6.143" PrivateAssets="All" />
47+
<PackageReference Include="Nerdbank.GitVersioning" Version="3.7.112" PrivateAssets="All" />
5248
</ItemGroup>
5349

5450
<ItemGroup>

test/Directory.Build.targets

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
<Project>
22
<ItemGroup>
3-
<!-- <PackageReference Include="Microsoft.TestPlatform.ObjectModel" Version="17.8.0" /> -->
43
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.10.0" />
5-
<PackageReference Include="xunit" Version="2.8.1" />
4+
<PackageReference Include="xunit" Version="2.9.2" />
65
<PackageReference Include="xunit.runner.visualstudio" Version="2.8.1">
76
<PrivateAssets>all</PrivateAssets>
87
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

test/TestableHttpClient.IntegrationTests/TestableHttpClient.IntegrationTests.csproj

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,13 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFrameworks>net462;net47;net48;net6.0;net8.0;net9.0</TargetFrameworks>
4+
<TargetFrameworks>net462;net47;net48;net8.0;net9.0</TargetFrameworks>
55
</PropertyGroup>
66

77
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
88
<PackageReference Include="System.Net.Http" Version="4.3.4" />
99
<PackageReference Include="System.Net.Http.Json" Version="[8.0.*,)" />
1010
</ItemGroup>
11-
12-
<ItemGroup Condition="'$(TargetFramework)' == 'net6.0'">
13-
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="[6.0.*,7.0.0)" />
14-
<PackageReference Include="Microsoft.Extensions.Http" Version="[6.0.*,7.0.0)" />
15-
<PackageReference Include="Microsoft.Extensions.Http.Polly" Version="[6.0.*,7.0.0)" />
16-
</ItemGroup>
1711

1812
<ItemGroup Condition="'$(TargetFramework)' == 'net8.0'">
1913
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="[8.0.*,9.0.0)" />

test/TestableHttpClient.Tests/TestableHttpClient.Tests.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFrameworks>net462;net47;net48;net6.0;net8.0;net9.0</TargetFrameworks>
4+
<TargetFrameworks>net462;net47;net48;net8.0;net9.0</TargetFrameworks>
55
</PropertyGroup>
66

77
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
8-
<PackageReference Include="System.Net.Http.Json" Version="6.0.2" />
8+
<PackageReference Include="System.Net.Http.Json" Version="8.0.1" />
99
</ItemGroup>
1010

1111
<ItemGroup>
12-
<PackageReference Include="NSubstitute" Version="5.1.0" />
12+
<PackageReference Include="NSubstitute" Version="5.3.0" />
1313
<PackageReference Include="NSubstitute.Analyzers.CSharp" Version="1.0.17">
1414
<PrivateAssets>all</PrivateAssets>
1515
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

0 commit comments

Comments
 (0)