Add default BaseAddress when calling CreateClient. (#263)

Fixes #261

Author: dnperfors

CHANGELOG.md

@@ -4,7 +4,7 @@ All notable changes to TestableHttpClient will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and 
 this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [0.11] - 2024-06-14
+## [0.11] - 2024-06-15
 ### Removed
 - .NET 7.0 target, since it is no longer supported
 - `ShouldHaveMadeRequestsTo(this TestableHttpMessageHandler, string, bool)` and `ShouldHaveMadeRequestsTo(this TestableHttpMessageHandler, string, bool, int)` have been removed. CaseInsensitivity is controlled by the `UriPatternMatchingOptions` that can be set on the `TestableHttpMessageHandler`.
@@ -16,6 +16,7 @@ this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 
 ### Added
 - Support for .NET 8
+- `CreateClient` now sets `https://localhost` as default BaseAddress on the created `HttpClient`.
 
 ## [0.10] - 2022-12-03
 ### Deprecated

src/TestableHttpClient/TestableHttpMessageHandlerExtensions.cs

@@ -2,6 +2,8 @@
 
 public static class TestableHttpMessageHandlerExtensions
 {
+    private const string DefaultBaseAddress = "https://localhost";
+
     /// <summary>
     /// Create an <seealso cref="HttpClient"/> configured with the TestableHttpMessageHandler.
     /// </summary>
@@ -37,7 +39,10 @@ public static HttpClient CreateClient(this TestableHttpMessageHandler handler, A
             throw new ArgumentNullException(nameof(httpMessageHandlers));
         }
 
-        var httpClient = new HttpClient(CreateHandlerChain(handler, httpMessageHandlers));
+        HttpClient httpClient = new(CreateHandlerChain(handler, httpMessageHandlers))
+        {
+            BaseAddress = new Uri(DefaultBaseAddress)
+        };
         configureClient(httpClient);
 
         return httpClient;

test/TestableHttpClient.Tests/TestableHttpMessageHandlerExtensionsTests/CreateClient.cs

@@ -25,6 +25,16 @@ public void CreateClient_CorrectTestableHttpMessageHandler_AddsHandlerToHttpClie
         Assert.Same(sut, handler);
     }
 
+    [Fact]
+    public void CreateClient_ByDefault_SetsBaseAddress()
+    {
+        using TestableHttpMessageHandler sut = new();
+
+        using var client = sut.CreateClient();
+
+        Assert.Equal(new Uri("https://localhost"), client.BaseAddress);
+    }
+
     [Fact]
     public void CreateClient_NullDelegateHandler_ThrowsArgumentNullException()
     {

test/TestableHttpClient.Tests/TestableHttpMessageHandlerExtensionsTests/CreateClientWithConfigurer.cs

@@ -38,6 +38,28 @@ static void configureClient(HttpClient client) { }
         Assert.Same(sut, handler);
     }
 
+    [Fact]
+    public void CreateClientWithConfigurer_ByDefault_SetsDefaultBaseAddress()
+    {
+        using TestableHttpMessageHandler sut = new();
+        static void configureClient(HttpClient client) { }
+
+        using var client = sut.CreateClient(configureClient);
+
+        Assert.Equal(new Uri("https://localhost"), client.BaseAddress);
+    }
+
+    [Fact]
+    public void CreateClientWithConfigurer_WhenConfiguringBaseAddress_DoesNotOverrideWithDefault()
+    {
+        using TestableHttpMessageHandler sut = new();
+        static void configureClient(HttpClient client) { client.BaseAddress = new Uri("https://example"); }
+
+        using var client = sut.CreateClient(configureClient);
+
+        Assert.Equal(new Uri("https://example"), client.BaseAddress);
+    }
+
     [Fact]
     public void CreateClientWithConfigurer_CallsConfigureClientWithClientToReturn()
     {

test/TestableHttpClient.Tests/TestableHttpMessageHandlerExtensionsTests/CreateClientWithConfigurerAndHttpMessageHandlers.cs

@@ -56,11 +56,11 @@ public void CreateClientWithConfigurerAndHttpMessageHandlers_WhenHttpMessageHand
     {
         using TestableHttpMessageHandler sut = new();
         static void configureClient(HttpClient _) { }
-        IEnumerable<DelegatingHandler> handlers = new DelegatingHandler[]
-        {
+        IEnumerable<DelegatingHandler> handlers =
+        [
             Substitute.For<DelegatingHandler>(),
             Substitute.For<DelegatingHandler>()
-        };
+        ];
 
         using var client = sut.CreateClient(configureClient, handlers);
 
@@ -71,5 +71,37 @@ static void configureClient(HttpClient _) { }
         Assert.Same(handlers.Last(), delegatingHandler2);
         Assert.Same(sut, delegatingHandler2.InnerHandler);
     }
+
+    [Fact]
+    public void CreateClientWithConfigurerAndHttpMessageHandlers_ByDefault_SetsDefaultBaseAddress()
+    {
+        using TestableHttpMessageHandler sut = new();
+        static void configureClient(HttpClient client) { }
+        IEnumerable<DelegatingHandler> handlers =
+        [
+            Substitute.For<DelegatingHandler>(),
+            Substitute.For<DelegatingHandler>()
+        ];
+
+        using var client = sut.CreateClient(configureClient, handlers);
+
+        Assert.Equal(new Uri("https://localhost"), client.BaseAddress);
+    }
+
+    [Fact]
+    public void CreateClientWithConfigurerAndHttpMessageHandlers_WhenConfiguringBaseAddress_DoesNotOverrideWithDefault()
+    {
+        using TestableHttpMessageHandler sut = new();
+        static void configureClient(HttpClient client) { client.BaseAddress = new Uri("https://example"); }
+        IEnumerable<DelegatingHandler> handlers =
+        [
+            Substitute.For<DelegatingHandler>(),
+            Substitute.For<DelegatingHandler>()
+        ];
+
+        using var client = sut.CreateClient(configureClient, handlers);
+
+        Assert.Equal(new Uri("https://example"), client.BaseAddress);
+    }
 }